Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

refactor: attendances, progress-tooltip and minor fixes #749

Merged
merged 17 commits into from
Dec 23, 2022
Merged

refactor: attendances, progress-tooltip and minor fixes #749

merged 17 commits into from
Dec 23, 2022

Conversation

derrabauke
Copy link
Contributor

Contents

This has become a real tutti frutti PR with some smaller fixes and some refactorings.

  • 4665c97 refactor(attendances): move actions to controller
  • 2ffa8e2 refactor(attendance-slider): octanify and fix tests
  • 3d4465c fix(sy-datepicker): prevent proxied date hicups
  • 68e6c96 fix: temporary prevent error
  • 8a37425 test: fix broken tests after codemods
  • eda4288 fix: date/durationpicker usages in templates
  • b64b62b fix(task-selection): reset selection correctly
  • 034999c test: setup mirage for response mocking
  • e688c25 refactor(progress-tooltip): octanify and fix tests
  • 1180b9b refactor(sy-datepicker): improve UX and fix tests
  • 20b197b test(report-row): refactor component invocation to octane
  • b1338fd test(index-controller): remove unnecessary service stub
  • 8eb6cd6 test(url-util): revert change in param parsing util

Info

20th PR of this series #710.
Only merge when #747 is merged and this PR got rebased!

@derrabauke derrabauke added the maintenance Code maintenance label Dec 21, 2022
@derrabauke derrabauke added this to the ember 3.28 milestone Dec 21, 2022
@derrabauke derrabauke self-assigned this Dec 21, 2022
@derrabauke derrabauke mentioned this pull request Dec 21, 2022
Merged
@derrabauke
test(url-util): revert change in param parsing util
13815e8
@derrabauke
test(index-controller): remove unnecessary service stub
b80edef
@derrabauke
test(report-row): refactor component invocation to octane
0da3639
@derrabauke
refactor(sy-datepicker): improve UX and fix tests
61537f7 
This reverts some changes from the past:
adfinis@7a0121e
But mainly it fixes the focus handling of the input.
@derrabauke
refactor(progress-tooltip): octanify and fix tests
1074a8a
@derrabauke
test: setup mirage for response mocking
5a40051
@derrabauke
fix(task-selection): reset selection correctly
b380295 
* fix model factory for testing
* fix selection (re-)set
@derrabauke
fix: date/durationpicker usages in templates
41ea7fa
@derrabauke
test: fix broken tests after codemods
36e783f
@derrabauke
fix: temporary prevent error
658d921 
Needs refactoring
@derrabauke
fix(sy-datepicker): prevent proxied date hicups
3708164
@derrabauke
refactor(attendance-slider): octanify and fix tests
87e901e
@derrabauke
refactor(attendances): move actions to controller
a5941d9
@derrabauke
fix(sy-durationpicker): splatter passed attributes
332d217 
* splatter attributes onto template
* add change listener to durationpicker-day input
@derrabauke
test(reports): repair test assertion
9831f17
velrest
velrest reviewed Dec 23, 2022
View reviewed changes
app/index/attendances/controller.js Show resolved Hide resolved
mirage/factories/user.js Outdated Show resolved Hide resolved
@derrabauke derrabauke merged commit 0c583d8 into adfinis:ember-octane Dec 23, 2022
@derrabauke derrabauke deleted the octane-pr-20 branch December 23, 2022 09:58
@derrabauke derrabauke mentioned this pull request Dec 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@velrest velrest velrest approved these changes

Assignees

@derrabauke derrabauke

Labels
maintenance Code maintenance
Projects
None yet
Milestone
ember 3.28
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabauke @velrest