fix(task-selection): reset selection correctly

* fix model factory for testing
* fix selection (re-)set

app/analysis/index/controller.js

@@ -189,6 +189,12 @@ export default class AnalysisController extends Controller.extend(
   @tracked _lastPage = 0;
   @tracked selectedReportIds;
 
+  @tracked user;
+  @tracked reviewer;
+  @tracked customer;
+  @tracked project;
+  @tracked task;
+
   setup() {
     this._dataCache = A();
     this.selectedReportIds = A();

app/components/task-selection/component.js

@@ -327,7 +327,7 @@ export default class TaskSelectionComponent extends Component {
       this.onProjectChange(null);
     }
 
-    if (!options.preventAction && this._customer) {
+    if (!options.preventAction) {
       later(this, () => {
         (this.args["on-set-customer"] === undefined
           ? () => {}
@@ -345,7 +345,6 @@ export default class TaskSelectionComponent extends Component {
       (value === null || value.get("id") !== this.task.get("project.id"))
     ) {
       this.onTaskChange(null);
-      return;
     }
 
     if (!this.customer && value?.get("customer.id")) {

mirage/factories/user.js

@@ -8,10 +8,24 @@ export default Factory.extend({
   email: () => faker.internet.email(),
   password: () => faker.internet.password(),
 
+  fullName() {
+    if (!this.firstName && !this.lastName) {
+      return "";
+    }
+
+    return `${this.firstName} ${this.lastName}`;
+  },
+
   username() {
     return `${this.firstName}${this.lastName.charAt(0)}`.toLowerCase();
   },
 
+  longName() {
+    return this.fullName
+      ? `${this.fullName} (${this.username})`
+      : this.username;
+  },
+
   isStaff: true,
   isActive: true,
   isSuperuser: false,