This repository has been archived by the owner on May 13, 2024. It is now read-only.
fix: mainly fix broken tests #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Break activitySum loop when in testing, otherwise it never settles * Use 'transition.send' for save event triggering in protected route * Assume 'this.user' is resolved later and could possibly be null
Restarting a task from the past will present the current date in the URL even though it should not be displayed, since it's the default QP for day. The QP handling is cumbersome so I decided it's ok to have it there for this special case. Please improve if possible.
derrabauke
force-pushed
the
octane-pr-19
branch
from
a19d9fe
to
22175e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
Special care
With a19d9fe I want to invite you, dear reviewer, to investigate with me, why this test is failing with the wrong
report-row-id. I could not figure out and therefore skipped the test.Info