Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

refactor: analysis views #743

Merged
merged 12 commits into from
Dec 22, 2022
Merged

refactor: analysis views #743

merged 12 commits into from
Dec 22, 2022

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented Dec 8, 2022 •
edited
Loading

Question

To parachute or not. This is the Question.

Contents

  • d77f2c2 fix(filter-sidebar): use correct QPs for filter sidebar
  • b124f57 test(analysis-edit): can not click disabled button via click
  • d87cdcf refactor(filter-sidebar): repair and octanify
  • 9c855b4 test(analysis): correct selectors and fix setup
  • ba31501 test(tracking): setup mock service
  • 4646420 fix(analysis): unintended queryParams reset when editing reports
  • 14bd695 refactor(analysis): query parameter setup
  • 4be6bdf refactor(analysis): octanify analysis routes
  • bcf6e18 chore: ignore window undef error
  • 304f730 refactor(tracking): prevent use of observers
  • 3514072 fix(tracking): show correct task duration sum

Info

17th PR of this series #710.
Only merge when #742 is merged and this PR got rebased!

@derrabauke derrabauke added the maintenance Code maintenance label Dec 8, 2022
@derrabauke derrabauke self-assigned this Dec 8, 2022
@derrabauke derrabauke changed the title WIP: refactor: analysis views Draft: refactor: analysis views Dec 8, 2022
@derrabauke derrabauke changed the title Draft: refactor: analysis views draft: refactor: analysis views Dec 8, 2022
@derrabauke derrabauke changed the title draft: refactor: analysis views Draft: refactor: analysis views Dec 8, 2022
@derrabauke derrabauke marked this pull request as draft December 8, 2022 12:59
@derrabauke derrabauke changed the title Draft: refactor: analysis views refactor: analysis views Dec 8, 2022
derrabauke and others added 2 commits December 12, 2022 13:34
@derrabauke
refactor(analysis): query parameter setup
14bd695
@velrest @derrabauke
fix(analysis): unintended queryParams reset when editing reports
4646420 
We serialize the ordering as null if the
value equals the defaultValue. For some reason
if the serialized value is not null we had some
weird query param behavior where the ordering
param was set to the defaultValue when editing
a report and due to that all other queryParams
where reset.
@derrabauke
test(tracking): setup mock service
ba31501
@derrabauke
test(analysis): correct selectors and fix setup
9c855b4 
Using a tracked task for customerAndRecentTasks getter fixes
issues where render-looping could occure.
@derrabauke
refactor(filter-sidebar): repair and octanify
d87cdcf 
User-Selection: move templates to optimized-power-select folder
Sy-Datepicker: resolve API to uniform standard and fix input focus
Tests: Update selectors to new component/dom structure
@derrabauke
test(analysis-edit): can not click disabled button via click
b124f57
@derrabauke
fix(filter-sidebar): use correct QPs for filter sidebar
d77f2c2 
* sy-modal: add modal only to dom when visible (lead to selector
  confusion)
@derrabauke derrabauke marked this pull request as ready for review December 15, 2022 10:57
@derrabauke derrabauke mentioned this pull request Dec 19, 2022
Merged
velrest
velrest reviewed Dec 22, 2022
View reviewed changes
app/analysis/index/controller.js Show resolved Hide resolved
app/analysis/index/controller.js Outdated Show resolved Hide resolved
app/analysis/index/controller.js Outdated Show resolved Hide resolved
app/analysis/index/controller.js Show resolved Hide resolved
app/application/template.hbs Show resolved Hide resolved
app/components/filter-sidebar/filter/template.hbs Outdated Show resolved Hide resolved
app/components/filter-sidebar/template.hbs Outdated Show resolved Hide resolved
app/components/sy-modal/template.hbs Show resolved Hide resolved
app/index/controller.js Show resolved Hide resolved
app/utils/url.js Outdated Show resolved Hide resolved
@derrabauke derrabauke merged commit fee6120 into adfinis:ember-octane Dec 22, 2022
@derrabauke derrabauke deleted the octane-pr-18 branch December 22, 2022 17:59
@derrabauke derrabauke mentioned this pull request Dec 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@velrest velrest velrest approved these changes

Assignees

@derrabauke derrabauke

Labels
maintenance Code maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabauke @velrest