Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix AdapterPlus config #775

Merged
merged 7 commits into from
Jan 6, 2025
Merged

[BUG] Fix AdapterPlus config #775

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
435f000
initial commit
julian-fong Jan 2, 2025
4903622
initial commit
julian-fong Jan 2, 2025
a181b36
updates
julian-fong Jan 5, 2025
3b5e09f
updates
julian-fong Jan 6, 2025
9cb4062
updates to docs regarding layer norm
julian-fong Jan 6, 2025
3aa2493
added word for clarity
julian-fong Jan 6, 2025
f2ecd3c
fixed code quality
julian-fong Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/adapters/configuration/adapter_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,9 @@ class AdapterPlusConfig(BnConfig):
The AdapterPlus config architecture proposed by Jan-Martin O, Steitz and Stefan Roth. See https://arxiv.org/pdf/2406.06820
"""

original_ln_after: bool = False
residual_before_ln: bool = True
original_ln_after: bool = True
calpt marked this conversation as resolved.
Show resolved Hide resolved
original_ln_before: bool = True
residual_before_ln: bool = False
stochastic_depth: float = 0.1
init_weights: str = "houlsby"
scaling: Union[float, str] = "channel"
Expand Down
Loading