Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix AdapterPlus config #775

Merged
merged 7 commits into from
Jan 6, 2025
Merged

[BUG] Fix AdapterPlus config #775

merged 7 commits into from
Jan 6, 2025

Conversation

julian-fong
Copy link
Contributor

@julian-fong julian-fong commented Jan 2, 2025 •
edited
Loading

This pr fixes the configuration parameters set in the AdapterPlusConfig

edit: This pr also incorporates some updates as described inside the comments in #764

  1. Added some more information regarding training configurations inside the AdapterPlusConfig and its corresponding notebook
  2. Added more info regarding layer norms inside the documentation

@julian-fong
Copy link
Contributor Author

@calpt The failures in test_adapter_models seem independent of the changes made in the pr I think, there is some IndexError related to a test test_inputs_embeds_matches_input_ids_with_generate in the Electra model.

@julian-fong julian-fong mentioned this pull request Jan 2, 2025
Closed
calpt
calpt approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!
would you mind also editing your ViT training notebook to reflect this change?

@julian-fong julian-fong requested a review from calpt January 6, 2025 03:06
calpt
calpt approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, the docs changes look good as well!

@calpt calpt merged commit d6054cb into adapter-hub:main Jan 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calpt calpt calpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julian-fong @calpt