Skip to content

Replace empty catch blocks with explicit exception handling in TarArchive validation methods #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamhathcock merged 2 commits into from
Jan 16, 2026
Merged

Replace empty catch blocks with explicit exception handling in TarArchive validation methods #1140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302cf2e
Initial plan
Copilot Jan 16, 2026
9fa686b
Fix empty catch blocks in TarArchive.Factory.cs with explicit excepti…
Copilot Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/SharpCompress/Archives/Tar/TarArchive.Factory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,12 @@ public static bool IsTarFile(Stream stream)
&& Enum.IsDefined(typeof(EntryType), tarHeader.EntryType);
return readSucceeded || isEmptyArchive;
}
catch { }
return false;
catch (Exception)
{
// Catch all exceptions during tar header reading to determine if this is a valid tar file
// Invalid tar files or corrupted streams will throw various exceptions
return false;
}
}

public static async ValueTask<bool> IsTarFileAsync(
Expand All @@ -182,8 +186,12 @@ public static async ValueTask<bool> IsTarFileAsync(
&& Enum.IsDefined(typeof(EntryType), tarHeader.EntryType);
return readSucceeded || isEmptyArchive;
}
catch { }
return false;
catch (Exception)
{
// Catch all exceptions during tar header reading to determine if this is a valid tar file
// Invalid tar files or corrupted streams will throw various exceptions
return false;
}
}

public static IWritableArchive CreateArchive() => new TarArchive();
Expand Down