Replace empty catch blocks with explicit exception handling in TarArchive validation methods#1140
Merged
adamhathcock merged 2 commits intoadam/async-creationfrom Jan 16, 2026
Conversation
…on handling Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on async creation cleanup pull request
Replace empty catch blocks with explicit exception handling in TarArchive validation methods
Jan 16, 2026
adamhathcock
approved these changes
Jan 16, 2026
This was referenced Feb 11, 2026
Closed
This was referenced Feb 23, 2026
This was referenced Mar 2, 2026
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback about empty catch blocks in
TarArchive.Factory.cs. TheIsTarFileandIsTarFileAsyncmethods use catch-all exception handling to detect invalid tar files, but the empty catch blocks obscured intent.Changes
catch { }with explicitcatch (Exception)in both validation methodsThe behavior is unchanged—these methods probe streams and return
falsefor any exception rather than propagating to callers.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.