Skip to content

feat(sccm): reduce Distribution Point content transactions - #474

Closed
adamgell wants to merge 11 commits into
codex/parser-family-skeletonfrom
codex/sccm329-dp-exact-profile-r152
Closed

feat(sccm): reduce Distribution Point content transactions#474
adamgell wants to merge 11 commits into
codex/parser-family-skeletonfrom
codex/sccm329-dp-exact-profile-r152

Conversation

@adamgell

@adamgell adamgell commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • adds evidence-first Distribution Point content transaction reduction
  • binds semantic identity to sealed topology and explicit package/content keys
  • preserves explicit coverage gaps and bounded source requests
  • requires the exact validated semantic source version 5.00.TEST.0001; intake-valid .0002 evidence cannot claim success

Dependency and merge order

Depends on #473 (SUP). This branch is issue-scoped against codex/parser-family-skeleton, but it was developed in parallel rather than as a descendant of the final SUP head. Keep this PR draft and restack/reverify it after #473 lands; do not merge out of order.

Current integration-base diff is limited to:

  • distribution_point.rs
  • server/windows/intake.rs
  • sccm_server_distribution_point.rs

Evidence

  • adversarial red first: .0002 remained intake-valid but incorrectly emitted a success transaction
  • focused DP: 22 passed
  • DP fixture contract: 48 passed
  • intake/SUP/spine aggregate: green
  • full parser suite: green
  • wasm32 check and strict Clippy: green
  • TypeScript: green
  • exact-range CodeRabbit: 0 findings
  • independent quality gate: ACCEPT, high confidence

State

  • exact head: 741520458556d63c0e3c8182c3f1feb16277307e
  • committed/pushed/reviewed: yes
  • merged: no
  • live Windows validated: no

Refs #329 and #317.

Predicted restack risk

A no-write git merge-tree --write-tree of DP 74152045 with final SUP 3cd037b9 is textually clean. The shared intake contract still changes materially: SUP binds next_artifact_requests into SccmServerIntakeIntegrity and tightens is_intact(). After #473 lands, restack and rerun the DP intake/reducer matrix to prove DP coverage gaps and bounded requests remain authorized by the final intake seal. No restack was performed in this review cycle.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 02131808-3c35-44e9-9038-f6b190fa8d1f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added enhancement New feature or request feature New feature parser Log parser related sccm SCCM/ConfigMgr related labels Aug 4, 2026
@adamgell
adamgell requested a review from Copilot August 4, 2026 03:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an evidence-first semantic reducer for SCCM Distribution Point content-distribution workflows, producing a single bounded “healthy transaction” only when canonical server intake is integrity-bound and matches an exact synthetic source/profile contract.

Changes:

  • Introduces analyze_distribution_point_content_from_server_intake and new DP content transaction/identity types, gated to the exact validated semantic source version (5.00.TEST.0001) and profile id.
  • Centralizes source-version profile eligibility behind server intake (including synthetic-fixture scoping) and reuses it in DP intake projection.
  • Expands DP test coverage to validate deterministic transaction reduction, conservative gap preservation, and bounded artifact requests (including the .0002 “intake-valid but must not claim success” case).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs Adds DP content semantic analysis + transaction identity, and updates intake projection to use intake-owned source-version eligibility.
crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs Stores synthetic-fixture provenance and exposes a reusable source-version eligibility predicate (with tests).
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs Adds fixtures/tests for DP content transaction reduction, profile gating, and bounded artifact request contracts.

@adamgell

adamgell commented Aug 5, 2026

Copy link
Copy Markdown
Owner Author

Superseded on main. This frozen DP slice supported only Succeeded; current main supports failure, retry, blocked, deferred, contradiction, incomplete, terminal evidence, and 14 scenarios/33 tests. Superseded by adedf2d and promoted through PR #490. Closing the dependent draft unmerged.

@adamgell adamgell closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature New feature parser Log parser related sccm SCCM/ConfigMgr related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants