feat(sccm): reduce Distribution Point content transactions - #474
feat(sccm): reduce Distribution Point content transactions#474adamgell wants to merge 11 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Adds an evidence-first semantic reducer for SCCM Distribution Point content-distribution workflows, producing a single bounded “healthy transaction” only when canonical server intake is integrity-bound and matches an exact synthetic source/profile contract.
Changes:
- Introduces
analyze_distribution_point_content_from_server_intakeand new DP content transaction/identity types, gated to the exact validated semantic source version (5.00.TEST.0001) and profile id. - Centralizes source-version profile eligibility behind server intake (including synthetic-fixture scoping) and reuses it in DP intake projection.
- Expands DP test coverage to validate deterministic transaction reduction, conservative gap preservation, and bounded artifact requests (including the
.0002“intake-valid but must not claim success” case).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs | Adds DP content semantic analysis + transaction identity, and updates intake projection to use intake-owned source-version eligibility. |
| crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs | Stores synthetic-fixture provenance and exposes a reusable source-version eligibility predicate (with tests). |
| crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs | Adds fixtures/tests for DP content transaction reduction, profile gating, and bounded artifact request contracts. |
Summary
5.00.TEST.0001; intake-valid.0002evidence cannot claim successDependency and merge order
Depends on #473 (SUP). This branch is issue-scoped against
codex/parser-family-skeleton, but it was developed in parallel rather than as a descendant of the final SUP head. Keep this PR draft and restack/reverify it after #473 lands; do not merge out of order.Current integration-base diff is limited to:
distribution_point.rsserver/windows/intake.rssccm_server_distribution_point.rsEvidence
.0002remained intake-valid but incorrectly emitted a success transactionState
741520458556d63c0e3c8182c3f1feb16277307eRefs #329 and #317.
Predicted restack risk
A no-write
git merge-tree --write-treeof DP74152045with final SUP3cd037b9is textually clean. The shared intake contract still changes materially: SUP bindsnext_artifact_requestsintoSccmServerIntakeIntegrityand tightensis_intact(). After #473 lands, restack and rerun the DP intake/reducer matrix to prove DP coverage gaps and bounded requests remain authorized by the final intake seal. No restack was performed in this review cycle.