feat(sccm): reduce healthy DP content transactions - #462
Conversation
|
@coderabbitai review Please review exact head 1ccfa10. This is the bounded healthy DP semantic slice only. Pay particular attention to sealed-intake authority, topology/site binding, deterministic key identity, coverage-gap preservation, confidence capping, timestamp provenance, and the no-cross-side-correlation boundary. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base="bc5d4f854362e31ffbfae46d9a07950955690887"
head="1ccfa109cea8440dab45d1ca7226083193496378"
printf '%s\n' '== Exact checkout state =='
git rev-parse HEAD
git cat-file -e "${base}^{commit}"
git cat-file -e "${head}^{commit}"
printf '%s\n' '== Changed files in requested range =='
git diff --name-status "$base" "$head"
printf '%s\n' '== AST outlines =='
ast-grep outline crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs --items all --view expanded
ast-grep outline crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs --items all --view expanded
ast-grep outline crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs --items all --view expanded
printf '%s\n' '== Exact range diff =='
git diff --find-renames --find-copies --unified=80 "$base" "$head" -- \
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs \
crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs
printf '%s\n' '== Intake and DP reducer definitions/usages =='
rg -n -C 4 --type rust \
'Sealed|sealed|DistributionPoint|distribution_point|reduce.*[Dd]istribution|[Dd]istribution.*reduce|topology|SiteCode|site_code|coverage|confidence|timestamp' \
crates/cmtraceopen-parser/src/sccm crates/cmtraceopen-parser/testsLength of output: 201899 🏁 Script executed: #!/bin/bash
set -euo pipefail
base="bc5d4f854362e31ffbfae46d9a07950955690887"
head="1ccfa109cea8440dab45d1ca7226083193496378"
printf '%s\n' '== Requested head verification =='
printf 'HEAD: '
git rev-parse HEAD
printf 'Requested: '
git rev-parse "$head"
printf '%s\n' '== Diff statistics =='
git diff --stat "$base" "$head" -- \
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs \
crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs
printf '%s\n' '== Exact unified diff =='
git diff --unified=25 "$base" "$head" -- \
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs \
crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs
printf '%s\n' '== distribution_point.rs =='
nl -ba crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs
printf '%s\n' '== intake.rs =='
nl -ba crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs
printf '%s\n' '== Direct construction and invocation sites =='
rg -n -C 8 --type rust \
'(SealedServer|ServerIntake|DistributionPoint.*(Reducer|Transaction)|reduce_distribution|distribution_point)' \
crates/cmtraceopen-parser/src/sccm/server/windows \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rsLength of output: 84183 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== distribution_point.rs, current source =='
sed -n '1,1250p' crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs
printf '%s\n' '== intake.rs: assessment integrity and profile eligibility =='
sed -n '1,280p' crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs
sed -n '2270,2425p' crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs
printf '%s\n' '== DP integration tests, current source =='
sed -n '1,1100p' crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs
printf '%s\n' '== Semantic-reducer exports and direct callers =='
rg -n -C 5 --type rust \
'\banalyze_distribution_point_content_from_server_intake\s*\(|SccmDistributionPointContent|pub\s+mod\s+distribution_point|pub\s+use.*distribution_point' \
crates/cmtraceopen-parser/src crates/cmtraceopen-parser/tests
printf '%s\n' '== DP fixtures =='
fd -t f . crates/cmtraceopen-parser/tests/fixtures/sccm/server/distribution_point | sort
printf '%s\n' '== Healthy-package manifest and evidence =='
find crates/cmtraceopen-parser/tests/fixtures/sccm/server/distribution_point/healthy-package \
-type f -maxdepth 3 -print -exec sh -c 'echo "--- $1"; sed -n "1,240p" "$1"' _ {} \;
printf '%s\n' '== Targeted test names =='
rg -n --type rust \
'fn .*?(profile|version|timestamp|time|phase|topology|site|coverage|correl|authority|identity|duplicate|revers)' \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rsLength of output: 166125 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '== Healthy evidence records =='
find crates/cmtraceopen-parser/tests/fixtures/sccm/server/distribution_point/healthy-package/evidence \
-type f -print -exec sh -c 'echo "--- $1"; cat "$1"' _ {} \;
printf '%s\n' '== DP fixture documentation =='
cat crates/cmtraceopen-parser/tests/fixtures/sccm/server/distribution_point/README.md
printf '%s\n' '== Complete DP integration-test tail =='
sed -n '430,1120p' crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs
printf '%s\n' '== Fixture-contract consumers and expected-file validation =='
rg -n -C 6 --type rust \
'(distribution_point|distribution-point|healthy-package|content-version-mismatch|expected\.json|transactionId|ProfileVersion|ProfileId)' \
crates/cmtraceopen-parser/tests
printf '%s\n' '== Cross-side and client-side references in the changed reducer =='
rg -n -C 4 --type rust \
'(client|cross.?side|correlat|join|analyze_.*client|client_.*analyze)' \
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs
printf '%s\n' '== Timestamp and phase adversarial coverage in DP tests =='
rg -n -C 5 --type rust \
'(timestamp|utc_millis|offset|revers|equal|duplicate.*(phase|token)|Phase=|Terminal=|ContentVersion|ProfileId)' \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs \
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rsLength of output: 202022
I reviewed exact head The reducer accepts only integrity-bound The reducer binds The deterministic key and transaction ID include package ID, content ID, content version, DP handle, message site token, sealed topology-site handle, and profile ID/version. The reducer requires all six phases. It requires role-local source mapping, exact terminal placement, and strictly increasing normalized UTC timestamps. Time does not form the transaction key. The reducer retains source and semantic coverage gaps. It emits bounded artifact requests. Any retained gap reduces emitted healthy transactions from The reviewed reducer has no client-side input or cross-side join path. It reports I did not execute the test suite in this static review environment. You are interacting with an AI system. |
There was a problem hiding this comment.
Pull request overview
Implements the first “healthy-only” semantic reducer for SCCM Distribution Point (DP) content transactions, building deterministic transactions exclusively from integrity-bound server intake evidence and preserving explicit coverage gaps/artifact requests when evidence is incomplete.
Changes:
- Added a DP content semantic reducer (
analyze_distribution_point_content_from_server_intake) with a strict six-phase “healthy” chain and deterministic transaction identity. - Extended server intake assessment to retain synthetic-fixture provenance and centralize the source-version profile eligibility predicate.
- Added/expanded integration tests to validate identity binding, site-token sealing, coverage-gap preservation, and determinism.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs | Adds DP content semantic analysis types + reducer; extends coverage-gap → artifact-request behavior. |
| crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs | Retains synthetic fixture flag in assessment and reuses the source-version eligibility predicate downstream. |
| crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs | Adds fixtures/tests for sealed healthy transaction reduction, gap preservation, and deterministic outputs. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@coderabbitai review Please review exact head 42a7e69. The only new commit closes the valid recovery-request finding by requesting the complete bounded healthy-profile source set. Independent exact-range review and local CodeRabbit are green; no failure/retry, Pull DP, correlation, native, or live behavior was added. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base="bc5d4f854362e31ffbfae46d9a07950955690887"
previous="1ccfa109cea8440dab45d1ca7226083193496378"
head="42a7e69c5540e8f1e2206801d7b52d7c43f4e5c0"
printf '%s\n' '== Exact commit verification =='
printf 'checkout: '; git rev-parse HEAD
printf 'base: '; git rev-parse "$base"
printf 'previous: '; git rev-parse "$previous"
printf 'requested: '; git rev-parse "$head"
git merge-base --is-ancestor "$previous" "$head"
printf '%s\n' 'previous is an ancestor of requested head'
printf '%s\n' '== Incremental changed files =='
git diff --name-status "$previous" "$head"
printf '%s\n' '== Incremental diff =='
git diff --find-renames --find-copies --unified=80 "$previous" "$head" -- \
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs \
crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs
printf '%s\n' '== Reducer structure =='
ast-grep outline crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs --items all --view expanded
ast-grep outline crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs --items all --view expanded
ast-grep outline crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs --items all --view expanded
printf '%s\n' '== Artifact-request, coverage, profile-source, and boundary references =='
rg -n -C 8 --type rust \
'(artifact.?request|ArtifactRequest|PkgXferMgr|pkgXferMgr|DistMgr|distmgr|SmsDpProv|smsDpProv|coverage|confidence|Pull DP|pull.?dp|cross.?side|correlat|topology|site.code|SiteCode)' \
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs \
crates/cmtraceopen-parser/src/sccm/server/windows/intake.rs \
crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rsLength of output: 202338 🏁 Script executed: #!/bin/bash
set -euo pipefail
previous="1ccfa109cea8440dab45d1ca7226083193496378"
head="42a7e69c5540e8f1e2206801d7b52d7c43f4e5c0"
file="crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rs"
test_file="crates/cmtraceopen-parser/tests/sccm_server_distribution_point.rs"
printf '%s\n' '== Exact incremental diff only =='
git diff --check "$previous" "$head"
git diff --unified=30 "$previous" "$head" -- "$file" "$test_file"
printf '%s\n' '== Artifact request implementation =='
rg -n -C 20 --type rust \
'fn artifact_requests|fn request|SccmArtifactRequest|gap\.producer_role|producer_role.*SiteServer|DistributionPoint' \
"$file"
printf '%s\n' '== Exact correction test cases =='
rg -n -C 16 --type rust \
'expected_(site_server_artifact_requests|all_dp_profile_artifact_requests|dp_artifact_requests)|artifact_request_contracts|no_declared_dp_source_requests|semantic_analysis_preserves|sealed_guard_rejection|artifact_requests_cover_required_sources' \
"$test_file" "$file"
printf '%s\n' '== Scope check for newly added references =='
git diff --unified=0 "$previous" "$head" -- "$file" "$test_file" \
| rg -n '^[+](?![+])' \
| rg -i '(pull|client|correlat|native|windows|retry|failure|pkgxfer|distmgr|smsdpprov|artifact)' || trueLength of output: 132212
I reviewed exact head The correction updates only the DP artifact-request behavior and its tests.
The implementation retains deterministic request sorting and full-identity deduplication. The added unit test checks each scope, duplicate gaps, and reversed gap order. The integration tests check logical ID, role, and reason for the affected sealed-intake, coverage, semantic-gap, and unscoped cases. The diff does not add Pull DP, failure or retry analysis, client correlation, native collection, or live behavior. It does not change sealed-intake authority, topology and site binding, transaction identity, timestamp provenance, coverage-gap confidence capping, or the no-cross-side-correlation boundary.
You are interacting with an AI system. |
Scope
Implements the first bounded semantic reducer slice for the SCCM Distribution Point workflow: a fully healthy, role-local package/content transaction admitted only from the sealed server-intake assessment.
This is issue #329 work. It does not close the issue and does not implement failure/retry diagnosis, native collection, client/server correlation, or live Windows acceptance.
Evidence-first contract
Exact range
Base:
bc5d4f854362e31ffbfae46d9a07950955690887Head:
42a7e69c5540e8f1e2206801d7b52d7c43f4e5c0Changed files:
crates/cmtraceopen-parser/src/sccm/server/windows/distribution_point.rscrates/cmtraceopen-parser/src/sccm/server/windows/intake.rscrates/cmtraceopen-parser/tests/sccm_server_distribution_point.rsReview corrections applied
Independent review rejected the first candidate and drove three fail-closed corrections:
Exact-head Copilot then found a valid recovery-request gap: the six-phase profile requires Transfer from
PkgXferMgr.log, while site-server and unscoped gaps requested onlydistmgr. The correction now emits the exact bounded sets:distmgr,pkgXferMgrdistmgr,pkgXferMgr,smsDpProvsmsDpProvOrdering, full request identity, roles, reasons, and deduplication are pinned. Pull DP is not requested. The exact correction received independent GO and local CodeRabbit zero findings.
Verification on exact head
Fresh hosted CodeRabbit, Copilot, CI, and zero-thread checks are required at exact head
42a7e69c; earlier hosted results are stale.Non-goals and dependencies
Failure/retry reducers remain stopped until this healthy slice completes hosted review. The content-to-DP correlation dependency in #333 remains blocked until stable upstream client content facts also exist. No native server capture or SCCM lab acceptance is claimed.