Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml migration #148

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Jun 1, 2023

Resubmitting the same changes (plus a minor few extra) from #145, with the idea I'll follow through on getting it to pass CI as necessary (though I can't see the old logs anymore so this first one might just be to see what's still left):

Changes for migrating from setup.py to pyproject.toml. Changes include:

  • Migratation from setup.py to pyproject.toml
  • Remove ez_setup.py because pyproject.toml handles downloading build dependencies (setuptools)
  • Also therefore removes ez_setup as a module
  • Updates workflow files
  • Builds a pure Python wheel for PyPI upload, along with the source distribution

Resolves #143

@tekktrik tekktrik changed the title Dev/pyproject-toml-migration pyproject.toml migration Jun 1, 2023
@tekktrik tekktrik requested a review from brentru June 1, 2023 03:50
@tekktrik tekktrik force-pushed the dev/pyproject-toml-migration branch 3 times, most recently from 30e3fc9 to 3466ffd Compare June 1, 2023 05:05
@tekktrik
Copy link
Member Author

tekktrik commented Jun 1, 2023

Alright, this passes my copy of GitHub Actions on the local repo

@tekktrik
Copy link
Member Author

tekktrik commented Jun 1, 2023

@brentru are the secrets up to date for this repository? It's failing pretty much all the unittests despite passing locally as well as in my fork with my credentials.

@tekktrik
Copy link
Member Author

tekktrik commented Jun 1, 2023

Actually, I think it's because secrets aren't available to non-authorized users in PRs, I ran into this for Adabot PRs.

@brentru
Copy link
Member

brentru commented Jun 1, 2023

@tekktrik I'm ok cleaning up the user access on this, could you email me/discord me what permissions need to be set in order for you to complete this migration?

@tekktrik
Copy link
Member Author

tekktrik commented Jun 1, 2023

Sure!

@brentru
Copy link
Member

brentru commented Nov 6, 2023

@tekktrik Could you take another look at this PR? I am not sure what it needs exactly.

@tekktrik
Copy link
Member Author

I'll try to take another look within the next couple weeks. I put things down for a few months and am picking back up now.

@tekktrik
Copy link
Member Author

tekktrik commented Jan 3, 2024

I'll resolve the merge conflicts and update a few things this weekend and give it another shot. I can send you what I think is needed in a list here or Discord if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to pyproject.toml
2 participants