Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml #145

Closed
wants to merge 5 commits into from
Closed

Migrate to pyproject.toml #145

wants to merge 5 commits into from

Conversation

tekktrik
Copy link
Member

Changes for migrating from setup.py to pyproject.toml. Changes include:

  • Migratation from setup.py to pyproject.toml
  • Remove ez_setup.py because pyproject.toml handles downloading build dependencies (setuptools)
  • Also therefore removes ez_setup as a module
  • Updates workflow files
  • Builds a pure Python wheel for PyPI upload, along with the source distribution

Resolves #143

@tekktrik tekktrik requested a review from brentru August 15, 2022 05:00
@brentru
Copy link
Member

brentru commented Aug 15, 2022

@tekktrik Could you also update the "manual installation" section of the README to add instructions for manually installing Adafruit IO Python after this migration?

https://github.com/adafruit/Adafruit_IO_Python#manual-installation

@tekktrik
Copy link
Member Author

Yup! PR already includes the updated manual installation command! Additional change is that CI takes care of updating version strings, by the way. Manual installs will be version 0.0.0.

@tekktrik tekktrik mentioned this pull request Aug 18, 2022
@tekktrik
Copy link
Member Author

@brentru let me know if any additional changes are needed

@ofek
Copy link

ofek commented Aug 24, 2022

Hey! What do we think about using the build backend hatchling (of which I am a maintainer in the PyPA) as that is now the default in the official Python packaging tutorial. Hatchling is available on all the major distribution channels such as Debian, Fedora, Arch Linux, conda-forge, Nixpkgs, Alpine Linux, FreeBSD, Gentoo Linux, MacPorts, OpenEmbedded, Spack, etc.

@tekktrik
Copy link
Member Author

My personal vote would be to transition to a setuptools backend to match the few hundred libraries we just migrated to be that so they all match. If we want to transition all of these in the future that's worth exploring, but probably out of scope for this PR, which is just to move away from setup.py.

@tekktrik
Copy link
Member Author

@brentru I think I might have fixed the previous issue, so just need approval for the CI again

@tekktrik
Copy link
Member Author

@brentru is anything still needed before CI run?

@tekktrik
Copy link
Member Author

tekktrik commented Sep 8, 2022

@brentru is this good to run?

@tekktrik
Copy link
Member Author

I think I'll continue to touch this up when I have a little more time, but closing in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to pyproject.toml
3 participants