Skip to content

Add fixes for simpletest example #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FoamyGuy merged 2 commits into from
Sep 12, 2022
Merged

Add fixes for simpletest example #16

FoamyGuy merged 2 commits into from
Sep 12, 2022

Conversation

@tekktrik
Copy link
Member

@tekktrik tekktrik commented Aug 31, 2022

  • Added example for generating private key
  • Added code and comments in simpletest example pointing to generation example file
  • Fixed type hint and docstring of private_key_data argument in JWT.generate()

Fixes #12

@tekktrik tekktrik requested a review from a team August 31, 2022 03:24
@brentru
Copy link
Member

brentru commented Aug 31, 2022

@tekktrik It's been a while since I've looked at this codebase. Where is the example code from? A learn guide?

@tekktrik
Copy link
Member Author

tekktrik commented Aug 31, 2022

@brentru yep: https://learn.adafruit.com/pyportal-iot-plant-monitor-with-google-cloud-iot-core-and-circuitpython/code-setup#creating-a-rsa-key-pair-3038069-14

FoamyGuy
FoamyGuy approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested successfully on PyPortal 8.0.0 beta.0

Thanks for adding the generator script and point in the right direction error handling @tekktrik!

@FoamyGuy FoamyGuy merged commit 7203a35 into adafruit:main Sep 12, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 13, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@de8f88a)
c80f101 
Updating https://github.com/adafruit/Adafruit_CircuitPython_HCSR04 to 0.4.14 from 0.4.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#29 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7565 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7565#5 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.8 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#17 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.14 from 1.5.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#33 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.11 from 2.22.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#174 from snkYmkrct/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.13 from 1.2.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_JWT#16 from tekktrik/dev/issue-12

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.19 from 2.4.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#33 from duckythescientist/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

document or add example of generating rsa key

3 participants

@tekktrik @brentru @FoamyGuy