Skip to content

Conversation

@snkYmkrct
Copy link
Contributor

Please see my comment on issue #169

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think your findings posted in the issue are correct.

Tested the solution from PR branch successfully with:

Adafruit CircuitPython 8.0.0-beta.0 on 2022-08-18; Adafruit PyPortal with samd51j20
Board ID:pyportal

In case it may be helpful in the future, here is the test code I used to verify the issue and fix:

import time
import board
import terminalio
from adafruit_display_text import bitmap_label

text = "Hello world"
text_area = bitmap_label.Label(terminalio.FONT, text=text)
text_area.x = 10
text_area.y = 10

text_area.label_direction = "UPR"
text_area.label_direction = "UPR"  # second time we set it causes trouble

board.DISPLAY.show(text_area)

val = 0
while True:
    val += 1
    text_area.text = f"Hello World {val}"
    time.sleep(0.3)

@FoamyGuy FoamyGuy merged commit 41f06c3 into adafruit:main Sep 12, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants