Change deployment workflows to trigger on push instead of release #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmgross
approved these changes
Oct 11, 2021
liflih
referenced
this pull request
Oct 12, 2021
ashwinsangem
pushed a commit
that referenced
this pull request
Oct 22, 2021
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * correct typo in msvc.properties.json Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Daniel Winsor <[email protected]>
ashwinsangem
pushed a commit
that referenced
this pull request
Oct 25, 2021
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * correct typo in msvc.properties.json * Removed the dummy templates used in bug_bash. Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Daniel Winsor <[email protected]>
ashwinsangem
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Adding MobSF starter workflow * Adhering to pull request guidelines * python: update to use python 3.10 Signed-off-by: Rui Chen <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add ruby and update workflow * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * quote the version strings * correct typo in msvc.properties.json * Update codeql.properties.json * Update code-scanning/properties/codeql.properties.json Co-authored-by: Arthur Baars <[email protected]> * Update codeql.properties.json * Update codeql.properties.json * Update code-scanning/mobsf.yml Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/mobsf.properties.json Co-authored-by: Nick Fyson <[email protected]> * Fixed typo in workflow that will cause every run to fail * Update commit SHA * r: use setup-r@1 and include r@4 for starter (#1169) * r: use setup-r@1 and include r@4 for starter Signed-off-by: Rui Chen <[email protected]> * use sha instead of tag for external action Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Josh Gross <[email protected]> * elixir: refresh dependencies (#1212) - setup action got renamed into `setup-beam` - update elixir and erlang versions Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Rui Chen <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Daniel Winsor <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Arthur Baars <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Marco Gario <[email protected]> Co-authored-by: Andy McKay <[email protected]>
ashwinsangem
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Adding MobSF starter workflow * Adhering to pull request guidelines * python: update to use python 3.10 Signed-off-by: Rui Chen <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add ruby and update workflow * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * quote the version strings * correct typo in msvc.properties.json * Update codeql.properties.json * Update code-scanning/properties/codeql.properties.json Co-authored-by: Arthur Baars <[email protected]> * Update codeql.properties.json * Update codeql.properties.json * Update code-scanning/mobsf.yml Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/mobsf.properties.json Co-authored-by: Nick Fyson <[email protected]> * Fixed typo in workflow that will cause every run to fail * Update commit SHA * r: use setup-r@1 and include r@4 for starter (#1169) * r: use setup-r@1 and include r@4 for starter Signed-off-by: Rui Chen <[email protected]> * use sha instead of tag for external action Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Josh Gross <[email protected]> * elixir: refresh dependencies (#1212) - setup action got renamed into `setup-beam` - update elixir and erlang versions * Updated to main branch version. Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Rui Chen <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Daniel Winsor <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Arthur Baars <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Marco Gario <[email protected]> Co-authored-by: Andy McKay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this comment, @jeremyepling proposed that we should not use
releaseas a trigger in the deployment workflows. This PR updates the starter workflows to trigger on push to$default-branchinstead.Partially addresses https://github.com/github/docs-content/issues/5252
Corresponding docs PR: https://github.com/github/docs-internal/pull/22036