-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Data Factory CI starter workflow #1111
Conversation
@fedeoliv LGTM. On the bubbling up front, we use repo analysis in the backend of GitHub now, and templates are recommended based on these These are the The detection engine is based on |
@fedeoliv This can be presented as a regex and that can be the detection criteria for |
@NinadKavimandan thanks for the suggestion. I opened an issue to support ADF: Azure Data Factory support as a new tech_stack |
@fedeoliv is there any working example of this workflow? |
@NinadKavimandan I have one example here: https://github.com/fedeoliv/data-factory-workflows-demo. |
@fedeoliv Thanks for pointing to the example! |
@NinadKavimandan I made some refactoring on new versions of data-factory-validate and data-factory-export to simplify even more the GH actions usage. The |
@fedeoliv in that case, will |
@NinadKavimandan not anymore. I was thinking the best option to identify ADF resources would be checking if the repo has at least one of the following folders: Is it possible to make these validations on the repo analysis? |
@fedeoliv detection criteria cannot be based on the directory name. Is the presence of |
@NinadKavimandan that's a good one for sure :) |
@fedeoliv cool then! We can take either of these two routes now -
or
What would you prefer? Either seems fine to me. |
Also |
@NinadKavimandan I updated the |
@fedeoliv thanks for pointing to the example. This is really helpful! Going ahead with the merge. |
Looks like I don't have the option to merge 😢 |
This reverts commit 7f30309.
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]>
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * correct typo in msvc.properties.json Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Daniel Winsor <[email protected]>
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * correct typo in msvc.properties.json * Removed the dummy templates used in bug_bash. Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Daniel Winsor <[email protected]>
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Adding MobSF starter workflow * Adhering to pull request guidelines * python: update to use python 3.10 Signed-off-by: Rui Chen <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add ruby and update workflow * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * quote the version strings * correct typo in msvc.properties.json * Update codeql.properties.json * Update code-scanning/properties/codeql.properties.json Co-authored-by: Arthur Baars <[email protected]> * Update codeql.properties.json * Update codeql.properties.json * Update code-scanning/mobsf.yml Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/mobsf.properties.json Co-authored-by: Nick Fyson <[email protected]> * Fixed typo in workflow that will cause every run to fail * Update commit SHA * r: use setup-r@1 and include r@4 for starter (#1169) * r: use setup-r@1 and include r@4 for starter Signed-off-by: Rui Chen <[email protected]> * use sha instead of tag for external action Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Josh Gross <[email protected]> * elixir: refresh dependencies (#1212) - setup action got renamed into `setup-beam` - update elixir and erlang versions Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Rui Chen <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Daniel Winsor <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Arthur Baars <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Marco Gario <[email protected]> Co-authored-by: Andy McKay <[email protected]>
* Added Cloudrail according to instructions and existing examples * Adding Cloudrail according to documentation and examples * Oops * Add original Fortify on Demand workflow * Update Fortify on Demand workflow * Update Fortify on Demand supported languages * Add 3rd-party GitHub Actions disclaimer * Sysdig Secure Inline Scan with SARIF report to starter workflows * Added some extra comments, Github Actions V2 and changed env vars * Reviews from PR #1110 * Adding 'Dockerfile' to category list * Update according to PR review comments * File renames as requested in PR comments * Revert "Azure Data Factory CI starter workflow (#1111)" (#1146) This reverts commit 7f30309. * use env variables for user-set values (#1117) Co-authored-by: Josh Gross <[email protected]> * Apply suggestions from nickfyson's code review Co-authored-by: Nick Fyson <[email protected]> * removing "deployment" templates from sync-ghes (#1127) * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/sysdig-scan.properties.json Co-authored-by: Nick Fyson <[email protected]> * Changed svg logo * Rename sysdig.svg to sysdig-scan.svg * Switched svg logo (again) for a better fit * Rename fortify.json to fortify.properties.json * Correct character-case of "c" in Cloudrail * AWS template also used Docker * trigger on push instead of release (#1157) Co-authored-by: Josh Gross <[email protected]> * Adding MobSF starter workflow * Adhering to pull request guidelines * python: update to use python 3.10 Signed-off-by: Rui Chen <[email protected]> * Added new templates for 3 clouds. * Revert "Added new templates for 3 clouds." This reverts commit c765d63. * Add ruby and update workflow * Add workflow for Microsoft C++ Code Analysis * Updated action to meet guidelines * quote the version strings * correct typo in msvc.properties.json * Update codeql.properties.json * Update code-scanning/properties/codeql.properties.json Co-authored-by: Arthur Baars <[email protected]> * Update codeql.properties.json * Update codeql.properties.json * Update code-scanning/mobsf.yml Co-authored-by: Nick Fyson <[email protected]> * Update code-scanning/properties/mobsf.properties.json Co-authored-by: Nick Fyson <[email protected]> * Fixed typo in workflow that will cause every run to fail * Update commit SHA * r: use setup-r@1 and include r@4 for starter (#1169) * r: use setup-r@1 and include r@4 for starter Signed-off-by: Rui Chen <[email protected]> * use sha instead of tag for external action Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Josh Gross <[email protected]> * elixir: refresh dependencies (#1212) - setup action got renamed into `setup-beam` - update elixir and erlang versions * Updated to main branch version. Co-authored-by: Yoni Leitersdorf <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Ruud Senden <[email protected]> Co-authored-by: Manuel Boira Cuevas <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Nick Fyson <[email protected]> Co-authored-by: Sarah Edwards <[email protected]> Co-authored-by: Josh Gross <[email protected]> Co-authored-by: Aparna Ravindra <[email protected]> Co-authored-by: manuelbcd <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Rui Chen <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Daniel Winsor <[email protected]> Co-authored-by: David Verdeguer <[email protected]> Co-authored-by: Arthur Baars <[email protected]> Co-authored-by: Abir Majumdar <[email protected]> Co-authored-by: Marco Gario <[email protected]> Co-authored-by: Andy McKay <[email protected]>
This PR introduces the Azure Data Factory CI starter workflow.