Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Data Factory CI starter workflow #1111

Merged
merged 9 commits into from
Sep 29, 2021
Merged

Azure Data Factory CI starter workflow #1111

merged 9 commits into from
Sep 29, 2021

Conversation

fedeoliv
Copy link
Contributor

This PR introduces the Azure Data Factory CI starter workflow.

@fedeoliv fedeoliv requested a review from a team as a code owner September 21, 2021 18:38
@NinadKavimandan
Copy link
Contributor

@fedeoliv LGTM. On the bubbling up front, we use repo analysis in the backend of GitHub now, and templates are recommended based on these tech_stacks.

These are the tech_stacks we currently detect - https://github.com/github-starter-workflows/repo-analysis-partner/blob/main/tech_stacks.yml

The detection engine is based on Linguist detection, so the criteria of detection are inline with languages.yml.
You can raise an issue to request detection of Azure Data Factory as a tech_stack.

@NinadKavimandan
Copy link
Contributor

NinadKavimandan commented Sep 23, 2021

{
    "scripts":{
        "build":"node node_modules/@microsoft/azure-data-factory-utilities/lib/index"
    },
    "dependencies":{
        "@microsoft/azure-data-factory-utilities":"^0.1.5"
    }
}

@fedeoliv This can be presented as a regex and that can be the detection criteria for Azure Data Factory.

@fedeoliv
Copy link
Contributor Author

fedeoliv commented Sep 23, 2021

@NinadKavimandan thanks for the suggestion. I opened an issue to support ADF: Azure Data Factory support as a new tech_stack

@fedeoliv fedeoliv removed the request for review from a team September 23, 2021 12:13
@NinadKavimandan
Copy link
Contributor

@fedeoliv is there any working example of this workflow?

@fedeoliv
Copy link
Contributor Author

@NinadKavimandan I have one example here: https://github.com/fedeoliv/data-factory-workflows-demo.
I've been working on a step-by-step CI/CD tutorial for Azure docs (hopefully adding this starter template on the doc soon 😉)

@fedeoliv
Copy link
Contributor Author

@NinadKavimandan
Copy link
Contributor

@fedeoliv Thanks for pointing to the example!
Is having package.json with the aforementioned script not a requirement for the workflow to run successfully? I didn't see a package.json in your example repo either.

@fedeoliv
Copy link
Contributor Author

@NinadKavimandan I made some refactoring on new versions of data-factory-validate and data-factory-export to simplify even more the GH actions usage. The package.json is not needed anymore as it's now embedded in a Dockerfile.

@NinadKavimandan
Copy link
Contributor

@fedeoliv in that case, will package.json play any part?

@fedeoliv
Copy link
Contributor Author

fedeoliv commented Sep 27, 2021

@NinadKavimandan not anymore. I was thinking the best option to identify ADF resources would be checking if the repo has at least one of the following folders: dataflow, dataset, integrationRuntime, linkedService, trigger or pipeline. If someone is going to create a brand new ADF with a GitHub repo without any custom files (e.g. publish_config.json), the minimal assets we'll have is at least one of these folders.

Is it possible to make these validations on the repo analysis?

@NinadKavimandan
Copy link
Contributor

@fedeoliv detection criteria cannot be based on the directory name. Is the presence of publish_config.json good enough criteria?

@fedeoliv
Copy link
Contributor Author

@NinadKavimandan that's a good one for sure :)

@NinadKavimandan
Copy link
Contributor

@fedeoliv cool then! We can take either of these two routes now -

  • Merge this PR now, I will add support for Azure Data Factory tech_stack and update categories for your template props

or

  • You can update the categories to include Azure Data Factory right now and merge, whenever Azure Data Factory tech_stack is added to repo analysis, this template will be bubbled up.

What would you prefer? Either seems fine to me.

@NinadKavimandan
Copy link
Contributor

Also
If there's any repo with publish_config.json handy, please share.

@fedeoliv
Copy link
Contributor Author

@NinadKavimandan I updated the .properties to include the Azure Data Factory tech_stack. Also, I added a publish_config.json sample on my data-factory-workflows-demo repo. Thank you! 😉

@NinadKavimandan
Copy link
Contributor

@fedeoliv thanks for pointing to the example. This is really helpful!
Will keep you posted about the developments on the repo analysis side.

Going ahead with the merge.

@NinadKavimandan
Copy link
Contributor

Looks like I don't have the option to merge 😢
@ashwinsangem can you take a look and merge this PR?

@ashwinsangem ashwinsangem merged commit 7f30309 into actions:main Sep 29, 2021
ashwinsangem pushed a commit that referenced this pull request Oct 1, 2021
ashwinsangem pushed a commit that referenced this pull request Oct 1, 2021
ashwinsangem pushed a commit that referenced this pull request Oct 8, 2021
* Added Cloudrail according to instructions and existing examples

* Adding Cloudrail according to documentation and examples

* Oops

* Add original Fortify on Demand workflow

* Update Fortify on Demand workflow

* Update Fortify on Demand supported languages

* Add 3rd-party GitHub Actions disclaimer

* Sysdig Secure Inline Scan with SARIF report to starter workflows

* Added some extra comments, Github Actions V2 and changed env vars

* Reviews from PR #1110

* Adding 'Dockerfile' to category list

* Update according to PR review comments

* File renames as requested in PR comments

* Revert "Azure Data Factory CI starter workflow (#1111)" (#1146)

This reverts commit 7f30309.

* use env variables for user-set values (#1117)

Co-authored-by: Josh Gross <[email protected]>

* Apply suggestions from nickfyson's code review

Co-authored-by: Nick Fyson <[email protected]>

* removing "deployment" templates from sync-ghes (#1127)

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Changed svg logo

* Rename sysdig.svg to sysdig-scan.svg

* Switched svg logo (again) for a better fit

* Rename fortify.json to fortify.properties.json

Co-authored-by: Yoni Leitersdorf <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Manuel Boira Cuevas <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Nick Fyson <[email protected]>
Co-authored-by: Sarah Edwards <[email protected]>
Co-authored-by: Josh Gross <[email protected]>
Co-authored-by: Aparna Ravindra <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
ashwinsangem pushed a commit that referenced this pull request Oct 22, 2021
* Added Cloudrail according to instructions and existing examples

* Adding Cloudrail according to documentation and examples

* Oops

* Add original Fortify on Demand workflow

* Update Fortify on Demand workflow

* Update Fortify on Demand supported languages

* Add 3rd-party GitHub Actions disclaimer

* Sysdig Secure Inline Scan with SARIF report to starter workflows

* Added some extra comments, Github Actions V2 and changed env vars

* Reviews from PR #1110

* Adding 'Dockerfile' to category list

* Update according to PR review comments

* File renames as requested in PR comments

* Revert "Azure Data Factory CI starter workflow (#1111)" (#1146)

This reverts commit 7f30309.

* use env variables for user-set values (#1117)

Co-authored-by: Josh Gross <[email protected]>

* Apply suggestions from nickfyson's code review

Co-authored-by: Nick Fyson <[email protected]>

* removing "deployment" templates from sync-ghes (#1127)

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Changed svg logo

* Rename sysdig.svg to sysdig-scan.svg

* Switched svg logo (again) for a better fit

* Rename fortify.json to fortify.properties.json

* Correct character-case of "c" in Cloudrail

* AWS template also used Docker

* trigger on push instead of release (#1157)

Co-authored-by: Josh Gross <[email protected]>

* Added new templates for 3 clouds.

* Revert "Added new templates for 3 clouds."

This reverts commit c765d63.

* Add workflow for Microsoft C++ Code Analysis

* Updated action to meet guidelines

* correct typo in msvc.properties.json

Co-authored-by: Yoni Leitersdorf <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Manuel Boira Cuevas <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Nick Fyson <[email protected]>
Co-authored-by: Sarah Edwards <[email protected]>
Co-authored-by: Josh Gross <[email protected]>
Co-authored-by: Aparna Ravindra <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Daniel Winsor <[email protected]>
ashwinsangem pushed a commit that referenced this pull request Oct 25, 2021
* Added Cloudrail according to instructions and existing examples

* Adding Cloudrail according to documentation and examples

* Oops

* Add original Fortify on Demand workflow

* Update Fortify on Demand workflow

* Update Fortify on Demand supported languages

* Add 3rd-party GitHub Actions disclaimer

* Sysdig Secure Inline Scan with SARIF report to starter workflows

* Added some extra comments, Github Actions V2 and changed env vars

* Reviews from PR #1110

* Adding 'Dockerfile' to category list

* Update according to PR review comments

* File renames as requested in PR comments

* Revert "Azure Data Factory CI starter workflow (#1111)" (#1146)

This reverts commit 7f30309.

* use env variables for user-set values (#1117)

Co-authored-by: Josh Gross <[email protected]>

* Apply suggestions from nickfyson's code review

Co-authored-by: Nick Fyson <[email protected]>

* removing "deployment" templates from sync-ghes (#1127)

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Changed svg logo

* Rename sysdig.svg to sysdig-scan.svg

* Switched svg logo (again) for a better fit

* Rename fortify.json to fortify.properties.json

* Correct character-case of "c" in Cloudrail

* AWS template also used Docker

* trigger on push instead of release (#1157)

Co-authored-by: Josh Gross <[email protected]>

* Added new templates for 3 clouds.

* Revert "Added new templates for 3 clouds."

This reverts commit c765d63.

* Add workflow for Microsoft C++ Code Analysis

* Updated action to meet guidelines

* correct typo in msvc.properties.json

* Removed the dummy templates used in bug_bash.

Co-authored-by: Yoni Leitersdorf <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Manuel Boira Cuevas <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Nick Fyson <[email protected]>
Co-authored-by: Sarah Edwards <[email protected]>
Co-authored-by: Josh Gross <[email protected]>
Co-authored-by: Aparna Ravindra <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Daniel Winsor <[email protected]>
ashwinsangem pushed a commit that referenced this pull request Nov 15, 2021
* Added Cloudrail according to instructions and existing examples

* Adding Cloudrail according to documentation and examples

* Oops

* Add original Fortify on Demand workflow

* Update Fortify on Demand workflow

* Update Fortify on Demand supported languages

* Add 3rd-party GitHub Actions disclaimer

* Sysdig Secure Inline Scan with SARIF report to starter workflows

* Added some extra comments, Github Actions V2 and changed env vars

* Reviews from PR #1110

* Adding 'Dockerfile' to category list

* Update according to PR review comments

* File renames as requested in PR comments

* Revert "Azure Data Factory CI starter workflow (#1111)" (#1146)

This reverts commit 7f30309.

* use env variables for user-set values (#1117)

Co-authored-by: Josh Gross <[email protected]>

* Apply suggestions from nickfyson's code review

Co-authored-by: Nick Fyson <[email protected]>

* removing "deployment" templates from sync-ghes (#1127)

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Changed svg logo

* Rename sysdig.svg to sysdig-scan.svg

* Switched svg logo (again) for a better fit

* Rename fortify.json to fortify.properties.json

* Correct character-case of "c" in Cloudrail

* AWS template also used Docker

* trigger on push instead of release (#1157)

Co-authored-by: Josh Gross <[email protected]>

* Adding MobSF starter workflow

* Adhering to pull request guidelines

* python: update to use python 3.10

Signed-off-by: Rui Chen <[email protected]>

* Added new templates for 3 clouds.

* Revert "Added new templates for 3 clouds."

This reverts commit c765d63.

* Add ruby and update workflow

* Add workflow for Microsoft C++ Code Analysis

* Updated action to meet guidelines

* quote the version strings

* correct typo in msvc.properties.json

* Update codeql.properties.json

* Update code-scanning/properties/codeql.properties.json

Co-authored-by: Arthur Baars <[email protected]>

* Update codeql.properties.json

* Update codeql.properties.json

* Update code-scanning/mobsf.yml

Co-authored-by: Nick Fyson <[email protected]>

* Update code-scanning/properties/mobsf.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Fixed typo in workflow that will cause every run to fail

* Update commit SHA

* r: use setup-r@1 and include r@4 for starter (#1169)

* r: use setup-r@1 and include r@4 for starter

Signed-off-by: Rui Chen <[email protected]>

* use sha instead of tag for external action

Co-authored-by: Josh Gross <[email protected]>

Co-authored-by: Josh Gross <[email protected]>

* elixir: refresh dependencies (#1212)

- setup action got renamed into `setup-beam`
- update elixir and erlang versions

Co-authored-by: Yoni Leitersdorf <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Manuel Boira Cuevas <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Nick Fyson <[email protected]>
Co-authored-by: Sarah Edwards <[email protected]>
Co-authored-by: Josh Gross <[email protected]>
Co-authored-by: Aparna Ravindra <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Abir Majumdar <[email protected]>
Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: David Verdeguer <[email protected]>
Co-authored-by: Daniel Winsor <[email protected]>
Co-authored-by: David Verdeguer <[email protected]>
Co-authored-by: Arthur Baars <[email protected]>
Co-authored-by: Abir Majumdar <[email protected]>
Co-authored-by: Marco Gario <[email protected]>
Co-authored-by: Andy McKay <[email protected]>
ashwinsangem pushed a commit that referenced this pull request Nov 15, 2021
* Added Cloudrail according to instructions and existing examples

* Adding Cloudrail according to documentation and examples

* Oops

* Add original Fortify on Demand workflow

* Update Fortify on Demand workflow

* Update Fortify on Demand supported languages

* Add 3rd-party GitHub Actions disclaimer

* Sysdig Secure Inline Scan with SARIF report to starter workflows

* Added some extra comments, Github Actions V2 and changed env vars

* Reviews from PR #1110

* Adding 'Dockerfile' to category list

* Update according to PR review comments

* File renames as requested in PR comments

* Revert "Azure Data Factory CI starter workflow (#1111)" (#1146)

This reverts commit 7f30309.

* use env variables for user-set values (#1117)

Co-authored-by: Josh Gross <[email protected]>

* Apply suggestions from nickfyson's code review

Co-authored-by: Nick Fyson <[email protected]>

* removing "deployment" templates from sync-ghes (#1127)

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Update code-scanning/properties/sysdig-scan.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Changed svg logo

* Rename sysdig.svg to sysdig-scan.svg

* Switched svg logo (again) for a better fit

* Rename fortify.json to fortify.properties.json

* Correct character-case of "c" in Cloudrail

* AWS template also used Docker

* trigger on push instead of release (#1157)

Co-authored-by: Josh Gross <[email protected]>

* Adding MobSF starter workflow

* Adhering to pull request guidelines

* python: update to use python 3.10

Signed-off-by: Rui Chen <[email protected]>

* Added new templates for 3 clouds.

* Revert "Added new templates for 3 clouds."

This reverts commit c765d63.

* Add ruby and update workflow

* Add workflow for Microsoft C++ Code Analysis

* Updated action to meet guidelines

* quote the version strings

* correct typo in msvc.properties.json

* Update codeql.properties.json

* Update code-scanning/properties/codeql.properties.json

Co-authored-by: Arthur Baars <[email protected]>

* Update codeql.properties.json

* Update codeql.properties.json

* Update code-scanning/mobsf.yml

Co-authored-by: Nick Fyson <[email protected]>

* Update code-scanning/properties/mobsf.properties.json

Co-authored-by: Nick Fyson <[email protected]>

* Fixed typo in workflow that will cause every run to fail

* Update commit SHA

* r: use setup-r@1 and include r@4 for starter (#1169)

* r: use setup-r@1 and include r@4 for starter

Signed-off-by: Rui Chen <[email protected]>

* use sha instead of tag for external action

Co-authored-by: Josh Gross <[email protected]>

Co-authored-by: Josh Gross <[email protected]>

* elixir: refresh dependencies (#1212)

- setup action got renamed into `setup-beam`
- update elixir and erlang versions

* Updated to main branch version.

Co-authored-by: Yoni Leitersdorf <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Ruud Senden <[email protected]>
Co-authored-by: Manuel Boira Cuevas <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Nick Fyson <[email protected]>
Co-authored-by: Sarah Edwards <[email protected]>
Co-authored-by: Josh Gross <[email protected]>
Co-authored-by: Aparna Ravindra <[email protected]>
Co-authored-by: manuelbcd <[email protected]>
Co-authored-by: Abir Majumdar <[email protected]>
Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: David Verdeguer <[email protected]>
Co-authored-by: Daniel Winsor <[email protected]>
Co-authored-by: David Verdeguer <[email protected]>
Co-authored-by: Arthur Baars <[email protected]>
Co-authored-by: Abir Majumdar <[email protected]>
Co-authored-by: Marco Gario <[email protected]>
Co-authored-by: Andy McKay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants