Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-682: Fixes #3811: Ensure all failing commands throw exceptions. #3846

Merged
merged 1 commit into from
Sep 13, 2019
Merged

DT-682: Fixes #3811: Ensure all failing commands throw exceptions. #3846

merged 1 commit into from
Sep 13, 2019

Conversation

danepowell
Copy link
Contributor

Fixes #3811

Changes proposed

  • Check the task return code anywhere that a failing task could lead to an unexpected or bad outcome.
  • Remove extraneous calls to stopOnFail(). This method is only applicable to command stacks with multiple commands. Contrary to what the name implies, it does not stop the entire process on failure, it only stops the current stack, and at any rate it's true by default.

@danepowell danepowell added the Bug Something isn't working label Sep 10, 2019
@danepowell danepowell merged commit bdb003f into acquia:10.x Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexxed alexxed alexxed approved these changes

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DT-682: Failing commands should throw an exception
3 participants
@danepowell @adrianthedev @alexxed