Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-682: Failing commands should throw an exception #3811

Closed
danepowell opened this issue Aug 13, 2019 · 0 comments · Fixed by #3846
Closed

DT-682: Failing commands should throw an exception #3811

danepowell opened this issue Aug 13, 2019 · 0 comments · Fixed by #3846
Labels
Bug Something isn't working

Comments

@danepowell
Copy link
Contributor

danepowell commented Aug 13, 2019 •
edited
Loading

Followup to #3796

In that issue, we didn't check the return value from a BLT task so failures were not stopping execution. We fixed that one instance of the issue, but there may be others lurking.

I think it would be a safer design if BLT tasks threw an exception on failure, rather than having to check the return code with every task instance. We could implement in the BLT base task, or try to fix this upstream in Robo: consolidation/robo#891

This might involve quite a bit of refactoring, I haven't looked to see how often we use this pattern.
@danepowell danepowell added this to the Backlog milestone Aug 13, 2019
@danepowell danepowell changed the title Failing commands should throw an exception DT-682: Failing commands should throw an exception Aug 13, 2019
@danepowell danepowell mentioned this issue Aug 13, 2019
Closed
danepowell added a commit to danepowell/blt that referenced this issue Sep 4, 2019
@danepowell
DT-682: Fixes acquia#3811: Failing commands throw exception by default.
49ed4b5
@danepowell danepowell mentioned this issue Sep 4, 2019
Closed
danepowell added a commit to danepowell/blt that referenced this issue Sep 10, 2019
@danepowell
DT-682: Fixes acquia#3811: Ensure all failing commands throw exceptions.
4067dda
@danepowell danepowell mentioned this issue Sep 10, 2019
Merged
@danepowell danepowell added the Bug Something isn't working label Sep 11, 2019
danepowell added a commit that referenced this issue Sep 13, 2019
@danepowell
DT-682: Fixes #3811: Ensure all failing commands throw exceptions. (#…
bdb003f 
…3846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@danepowell