Skip to content

chore: fix up local stack #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ackintosh merged 1 commit into from
Aug 26, 2025
+4 −9
Merged

chore: fix up local stack #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
tools: composer
# Specific versions of extensions available on PECL can be set up by suffixing the extension's name with the version.
# https://github.com/shivammathur/setup-php?tab=readme-ov-file#heavy_plus_sign-php-extension-support
extensions: apcu, redis-5.3.7, memcached, mongodb
extensions: apcu, redis-5.3.7, memcached, mongodb-1.21.1
env:
fail-fast: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
tools: composer
# Specific versions of extensions available on PECL can be set up by suffixing the extension's name with the version.
# https://github.com/shivammathur/setup-php?tab=readme-ov-file#heavy_plus_sign-php-extension-support
extensions: apcu, redis-5.3.7, memcached, mongodb-1.21.0
extensions: apcu, redis-5.3.7, memcached, mongodb-1.21.1
ini-values: apc.enable_cli=1
coverage: xdebug
env:
Expand Down
6 changes: 0 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,12 +501,6 @@ $ganeshaClient->request('GET', 'http://api.example.com/awesome_resource');
You can also specify `$service` via a option passed to client, or request header. If both are specified, the option value takes precedence.

```php
// via constructor argument
$ganeshaClient = new GaneshaHttpClient($client, $ganesha, [
Copy link
Contributor Author

@marmichalski marmichalski Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

third argument is not an array, this was a lie 🤥

// 'ganesha.service_name' is defined as ServiceNameExtractor::OPTION_KEY
'ganesha.service_name' => 'specified_service_name',
]);
Comment on lines -505 to -508
Copy link
Contributor Author

@marmichalski marmichalski Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would there be any appetite to support the ganesha.service_name option through withOptions method?


// via request method argument
$ganeshaClient->request(
'GET',
Expand Down
3 changes: 2 additions & 1 deletion examples/client/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ COPY install_composer.sh /tmp/
RUN apt-get update \
&& apt-get install --no-install-recommends -y git \
&& apt-get install --no-install-recommends -y libmemcached-dev \
&& apt-get install --no-install-recommends -y libssl-dev \
Copy link
Contributor Author

@marmichalski marmichalski Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for libmemcached

&& apt-get install --no-install-recommends -y zlib1g-dev \
&& apt-get install --no-install-recommends -y unzip \
&& apt-get install --no-install-recommends -y libzip-dev \
Expand All @@ -17,7 +18,7 @@ RUN apt-get update \
&& echo 'extension=redis.so' >> /usr/local/etc/php/php.ini \
&& yes '' | pecl install xdebug-3.1.5 \
&& echo 'zend_extension=xdebug.so' >> /usr/local/etc/php/php.ini \
&& yes '' | pecl install mongodb \
&& yes '' | pecl install mongodb-1.21.1 \
Copy link
Contributor Author

@marmichalski marmichalski Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installs 2.x by default and composer requirement doesn't like it

&& echo 'extension=mongodb.so' >> /usr/local/etc/php/php.ini \
&& yes '' | pecl install apcu \
&& echo 'extension=apcu.so' >> /usr/local/etc/php/php.ini \
Expand Down
Loading