Merged
Conversation
marmichalski
commented
Jul 3, 2025
|
|
||
| ```php | ||
| // via constructor argument | ||
| $ganeshaClient = new GaneshaHttpClient($client, $ganesha, [ |
Contributor
Author
There was a problem hiding this comment.
third argument is not an array, this was a lie 🤥
marmichalski
commented
Jul 3, 2025
| RUN apt-get update \ | ||
| && apt-get install --no-install-recommends -y git \ | ||
| && apt-get install --no-install-recommends -y libmemcached-dev \ | ||
| && apt-get install --no-install-recommends -y libssl-dev \ |
Contributor
Author
There was a problem hiding this comment.
needed for libmemcached
marmichalski
commented
Jul 3, 2025
| && yes '' | pecl install xdebug-3.1.5 \ | ||
| && echo 'zend_extension=xdebug.so' >> /usr/local/etc/php/php.ini \ | ||
| && yes '' | pecl install mongodb \ | ||
| && yes '' | pecl install mongodb-1.21.1 \ |
Contributor
Author
There was a problem hiding this comment.
installs 2.x by default and composer requirement doesn't like it
marmichalski
commented
Jul 3, 2025
Comment on lines
-505
to
-508
| $ganeshaClient = new GaneshaHttpClient($client, $ganesha, [ | ||
| // 'ganesha.service_name' is defined as ServiceNameExtractor::OPTION_KEY | ||
| 'ganesha.service_name' => 'specified_service_name', | ||
| ]); |
Contributor
Author
There was a problem hiding this comment.
would there be any appetite to support the ganesha.service_name option through withOptions method?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.