[publication] Fix download prevention by overriding download notification function #9208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersoncasimir
added
the
26.0.0-bugs
driusan
reviewed
Apr 16, 2024
| * | ||
| * @return void | ||
| * | ||
| * @phan-suppress-next-line PhanUnusedProtectedMethodParameter |
There was a problem hiding this comment.
You can wait until the tests run to see if it ignores comments but I'm pretty sure "suppress-next-line" needs to go immediately above the line.
There was a problem hiding this comment.
I believe it looks after the comment: https://github.com/phan/phan/wiki/Annotating-Your-Source-Code#phan-suppress-next-line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9133.
An error regarding the non-existence of a
notification_modulewith module:publicationand operation:downloadprevented the downloading of files.The notification function was overridden for this module to bypass the
LorisExceptionthrown by the non-existence of entries. It appeared by far to be a simpler solution than checking for and adding extra logic when the entries do not exist.