[publication] Fix download prevention by overriding download notification function (#9208)

An error regarding the non-existence of a notification_module with module: publication and operation: download prevented the downloading of files.

The notification function was overridden for this module to bypass the LorisException thrown by the non-existence of entries. It appeared by far to be a simpler solution than checking for and adding extra logic when the entries do not exist.

Resolves  #9133.

Author: jeffersoncasimir

modules/publication/php/files.class.inc

@@ -1,4 +1,9 @@
 <?php
+
+// @phan-file-suppress PhanUnusedProtectedMethodParameter
+// Suppressed due to false-positive for doDownloadNotification function
+// Unused parameter $file required to match parent signature
+
 namespace LORIS\publication;
 
 /**
@@ -49,4 +54,16 @@ class Files extends \LORIS\Http\FilesPassthroughEndpoint
     {
         return "/files/";
     }
+
+    /**
+     * Send a notification for the download.
+     *
+     * @param string $file The filename being downloaded
+     *
+     * @return void
+     */
+    protected function doDownloadNotification($file)
+    {
+        // Not implemented for this module
+    }
 }