Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrument] ControlpanelDeleteInstrumentData error #8681

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Apr 26, 2023

Fix the error reported here: #8673 (review)
and make sure the btn works.
Regression introduced by #7018

fixes #7065

@laemtl laemtl mentioned this pull request Apr 26, 2023
@laemtl laemtl changed the base branch from main to 25.0-release April 26, 2023 18:22
@laemtl laemtl added this to the 25.0.0 milestone Apr 26, 2023
@laemtl laemtl requested a review from zaliqarosli April 26, 2023 18:23
@laemtl laemtl force-pushed the instrument-ControlpanelDeleteInstrumentData-error branch from b469998 to 7f1616d Compare April 26, 2023 18:31
@laemtl laemtl force-pushed the instrument-ControlpanelDeleteInstrumentData-error branch from 7f1616d to 8a0ceda Compare April 26, 2023 18:31
@zaliqarosli
Copy link
Contributor

i think this PR also solves #8580 @miladheshmati

@laemtl laemtl force-pushed the instrument-ControlpanelDeleteInstrumentData-error branch from 33fa615 to 09e4f8d Compare April 27, 2023 13:17
Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zaliqarosli zaliqarosli added the Passed manual tests PR has been successfully tested by at least one peer label Apr 27, 2023
@zaliqarosli
Copy link
Contributor

also looks to fix #7065

@zaliqarosli zaliqarosli linked an issue Apr 28, 2023 that may be closed by this pull request
@driusan driusan merged commit 06d27dc into aces:25.0-release May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25.0.0 - Bugs Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
3 participants