Remove SWAL library

[haoweiqiu]

Brief summary of changes

Try to remove SWAL library.

Link(s) to related issue(s)

• Resolves Remove SWAL from htdocs/vendor #6114 (Reference the issue this fixes, if any.)

[christinerogers]

Hi Laetitia @laemtl and Shen @kongtiaowang - Any ideas here for the integration test failures we're seeing in Travis?

[laemtl]

@christinerogers I investigated a few things with @haoweiqiu and they passed. Closing to see if we get the same result twice. Otherwise, my understanding is that we have to investigate each case individually to discover what's wrong.

[laemtl]

Made a small change and Travis is passing now.

[laemtl]

Find one last occurence that may be problematic in htdocs/js/instrument_controlpanel_swaldeletedata.js:

function swalFunction(event) {
  swal.fire({
    title: 'Please confirm deletion',
    text: 'The instrument data will be deleted',

referenced in smarty/templates/instrumentstatus_controlpanel.tpl.

[haoweiqiu]

Hi @laemtl I have also found this function. It was originally swal, but I changed to swal.fire (Sweetalert 2).

[laemtl]

@haoweiqiu It is not embedded in a react component so this change will not work. @maltheism, any suggestions?

[laemtl]

Fixed by reactifying the component (htdocs/js/instrument_controlpanel_swaldeletedata.js was migrated in modules/instruments/jsx/ControlpanelDeleteInstrumentData.js)

[christinerogers]

Hi @laemtl - could you comment on how this PR should move forward?
Is it still relevant - does it just need @haoweiqiu to rebase it?

[laemtl]

This PR is ready for review once it is rebased. I think it is still relevant, except if @ridz1208 or @driusan think otherwise.

[christinerogers]

@haoweiqiu would you be able to rebase this? Thank you -

[zaliqarosli]

@laemtl @ridz1208 @christinerogers guys i think we should probably keep this library until all modules are reactified? sweetalert2 only works if embedded in a react component.

i would like to use sweetalert in this PR https://github.com/aces/Loris/pull/7069/files targeting the non-reactified configuration module. how should i move forward? in my mind, i would like to keep our UI consistent across modules

[cmadjar]

@driusan to be discussed at the LORIS meeting.

[laemtl]

@maltheism This PR has been updated to address @zaliqarosli comment. It should be ready to go after a rebase.

[driusan]

@maltheism can you rebase again? I think I merged a different one of your PRs today that added a reference to it somewhere else, I want to be sure the tests still pass..

[maltheism]

@driusan I think this PR makes my other PR irrelevant. I manually tested the preview button of the help_editor module and it works correctly in this PR as well.

[driusan]

@maltheism conflicts in .eslintrc.json too