Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[raisinbread] Update EEG Acquisition Form #8675

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

regisoc
Copy link
Contributor

@regisoc regisoc commented Apr 25, 2023

Brief summary of changes

Added minor changes to EEG Acquisition Form.

Screeshots

1
2
3
4
5
6
7

Resolves #8491

@regisoc regisoc requested a review from christinerogers April 25, 2023 19:53
@regisoc regisoc self-assigned this Apr 25, 2023
@regisoc
Copy link
Contributor Author

regisoc commented Apr 25, 2023

@christinerogers ready for testing!

Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost perfect @regisoc - thanks for these updates. see change requests below, and please check all tasks

Not sure when I can test your next round of changes on a real Loris, but if they're available on your dev VM just after the Friday 11am EEG meeting that could be a great time if that's not inconvenient. let me know -

@regisoc regisoc requested a review from christinerogers May 5, 2023 14:30
@driusan
Copy link
Collaborator

driusan commented Jun 7, 2023

@regisoc / @christinerogers what is the status of this?

@regisoc
Copy link
Contributor Author

regisoc commented Jun 7, 2023

I did not touch it since last changes, so I would say awaiting review

Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @regisoc - these changes look good to me, approving 👍
I also edited the #8491 description so that to "Resolves" so that it will close when this is merged.

@driusan this is ready for merge for the 25 release.

@driusan driusan merged commit 706cd78 into aces:25.0-release Jun 16, 2023
@christinerogers christinerogers added this to the 25.0.0 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants