[dictionary] Add visits for session scoped variables to API #8426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR#6936 includes a /dictionary/module/(modulename) REST endpoint to act as an API which provides the dictionary for the QueryEngine of a module. This updates it to include the valid visits for which the data point is valid for session scoped variables.
driusan
added
Category: Feature
ridz1208
reviewed
Mar 11, 2023
ridz1208
approved these changes
Mar 11, 2023
Co-authored-by: Rida Abou-Haidar <[email protected]>
driusan
added a commit
to driusan/Loris
that referenced
this pull request
Mar 13, 2023
PR#6936 includes a /dictionary/module/(modulename) REST endpoint to act as an API which provides the dictionary for the QueryEngine of a module. This updates it to include the valid visits for which the data point is valid for session scoped variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#6936 includes a /dictionary/module/(modulename) REST endpoint to act as an API which provides the dictionary for the QueryEngine of a module.
This updates it to include the valid visits for which the data point is valid for session scoped variables.
Testing instructions (if applicable)
$LORISURL/dictionary/module/$modulenameand look at the JSON returned. Session scoped variables should include a visits key with an array of the correct visits for that variable.