[candidate_parameters] Add candidate parameters query engine #8288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Category: Feature
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
2 times, most recently
from
5b687f9 to
c409630
Compare
driusan
removed
the
State: Blocked
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
2 times, most recently
from
8363e0f to
41b781b
Compare
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
from
41b781b to
29e788e
Compare
This adds a Module->getQueryEngine() function to the Module class to get the QueryEngine to the module. The default is a NullQueryEngine which does nothing and matches nothing. Update the dictionary module to use the new interface instead of Module->getDataDictionary().
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
from
40dfb67 to
1d02b12
Compare
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
from
8f61662 to
d4cc1e8
Compare
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
from
2b1c1da to
79b3c3f
Compare
"Subproject" was replaced by "Cohort", so the "Sub" substring doesn't match anymore.
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
from
88de588 to
09e96f8
Compare
driusan
force-pushed
the
CandidateParametersQueryEngine
branch
from
09e96f8 to
cb86714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a candidate parameters query engine to deal with candidate meta-data from the candidate_parameters module for the
new data query API.
It also includes a new src/Data/Query/SQLQueryEngine.php abstract class to make it easier to build query engines based on SQL statements for modules where that can be done efficiently with a single statement for any dictionary terms in the data dictionary.