-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs - LORIS installation] Updated installation instructions to reflect the requirement of PHP 8.0+ #8223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @jeffersoncasimir LGTM.
The missing variable assignment was originally intended to avoid picking the directory name for new projects, but it was definitely leading to some confusion based on comments heard over the years, so being more explicit should be helpful.
@driusan @ridz1208 any objections on specifying $projectname
as loris
as Jefferson has added here? It should reduce friction for new installs adn they can always change the name when they walk through these steps.
@kongtiaowang could you please pull and test, and review ? thanks
I don't have any strong opinions on the variable but if we're going to hardcode the value we might as well get rid of the variable and just hardcode the path that uses it. |
@jeffersoncasimir ping.. are you going to get rid of the variable since it's hardcoded? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense.
docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install/Ubuntu/README.md
Outdated
Show resolved
Hide resolved
docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install/Ubuntu/README.md
Outdated
Show resolved
Hide resolved
docs/wiki/00_SERVER_INSTALL_AND_CONFIGURATION/01_LORIS_Install/Ubuntu/README.md
Outdated
Show resolved
Hide resolved
…/Ubuntu/README.md
…/Ubuntu/README.md
…/Ubuntu/README.md
Brief summary of changes
Link(s) to related issue(s)
Resolves #8220