Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[install] Update install docs - php 8 (loris main/25+) #8220

Closed
christinerogers opened this issue Nov 7, 2022 · 1 comment · Fixed by #8223
Closed

[install] Update install docs - php 8 (loris main/25+) #8220

christinerogers opened this issue Nov 7, 2022 · 1 comment · Fixed by #8223
Assignees
@jeffersoncasimir
Labels
Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Critical to release PR or issue is key for the release to which it has been assigned

Comments

@christinerogers
Copy link
Contributor

christinerogers commented Nov 7, 2022 •
edited
Loading

edited per Dave's comment: these changes should go only to main because Loris 24 still supports PHP 7.4

The basic dependencies for Loris are out of date in our docs - @jeffersoncasimir this can be your first issue.
All the install docs should be reviewed and updated for dependency versions, including for CentOS.

These updates should go on both the 24 branch and main branch using 1 PR for each branch.

Start with:

  • Update the Ubuntu install steps
  • create a PR (pull from your fork/branch for this task to aces/main branch), see other PRs in the Loris repo for examples -- this is your first-day goal
  • Add the Centos file update(s) and any other files that mention dependency versions (a quick grep could help) to your branch/PR
  • Double-Check with Shen @kongtiaowang - Are there any other dependency versions (e.g. node) that need to be updated?
  • when ready, request review from @kongtiaowang

In case it saves to have confirmed- the updated (ubuntu) library names are simply:
sudo apt install ...
php8.0
php8.0-mysql
php8.0-xml
php8.0-mbstring
php8.0-gd
php8.0-zip
php8.0-curl
libapache2-mod-php8.0
@christinerogers christinerogers added Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Critical to release PR or issue is key for the release to which it has been assigned labels Nov 7, 2022
@jeffersoncasimir jeffersoncasimir mentioned this issue Nov 7, 2022
Closed
@christinerogers
Copy link
Contributor Author

this issue edited to reflect changes to main, since Loris 24 still supports PHP 7.4

@jeffersoncasimir jeffersoncasimir mentioned this issue Nov 8, 2022
Merged
@christinerogers christinerogers changed the title [install] Update install docs - php version 8+ for 24.* [install] Update install docs - php version 8+ (25+) Nov 14, 2022
@christinerogers christinerogers changed the title [install] Update install docs - php version 8+ (25+) [install] Update install docs - php 8 (loris main/25+) Nov 14, 2022
driusan pushed a commit that referenced this issue Dec 13, 2022
@jeffersoncasimir
[Docs - LORIS installation] Updated installation instructions to refl…
a310108 
…ect the requirement of PHP 8.0+ (#8223)

- Modified the instructions to include the correct PHP library versions required for both Ubuntu and CentOS.
- Hardcoded path to `/var/www/loris/`
- Changed an argument of the chown command in 'Creating the lorisadmin user' to prevent unwanted side-effects of creating a user with a period in its name.

Resolves #8220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffersoncasimir jeffersoncasimir

Labels
Category: Bug PR or issue that aims to report or fix a bug Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Critical to release PR or issue is key for the release to which it has been assigned
Projects
None yet
Milestone
No milestone
2 participants
@christinerogers @jeffersoncasimir