Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RaisinBread] main branch - fix gitactions frozen - add physiological_* data for integration test #8142

Merged
merged 10 commits into from
Aug 3, 2022
Merged

[RaisinBread] main branch - fix gitactions frozen - add physiological_* data for integration test #8142

merged 10 commits into from
Aug 3, 2022

Conversation

kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Jul 14, 2022 •
edited
Loading

Brief summary of changes

fix gitactions frozen.
clean up - [EEG] Database Architecture for HED Tags #8036
modify - [RaisinBread] add physiological_* data for integration test
skip RecordingsTest (rewrite in the future)

Testing instructions (if applicable)

pass git action test

@kongtiaowang kongtiaowang added Testing PR contains test plan or automated test code (or config files for Travis) RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset labels Jul 14, 2022
@kongtiaowang kongtiaowang changed the title test [Raisin_Bread] fix physiological_* data for integration test Jul 14, 2022
@kongtiaowang kongtiaowang changed the title [Raisin_Bread] fix physiological_* data for integration test [Raisin_Bread] add physiological_* data for integration test Jul 15, 2022
@kongtiaowang kongtiaowang changed the title [Raisin_Bread] add physiological_* data for integration test [RaisinBread] add physiological_* data for integration test - fix gitactions frozen Jul 15, 2022
@kongtiaowang kongtiaowang changed the title [RaisinBread] add physiological_* data for integration test - fix gitactions frozen [RaisinBread] main branch - fix gitactions frozen - add physiological_* data for integration test Jul 26, 2022
@christinerogers
Copy link
Contributor

christinerogers commented Aug 2, 2022 •
edited
Loading

Thanks for this @kongtiaowang so that @jesscall 's HED tag support #8036 won't break the auto-tests on RaisinBread.
Given you invoked skipping tests - Is there a cleanup issue for how these tests (and others) should actually be eventually updated ? just so it doesn't fall off the radar...

AlexandraLivadas
AlexandraLivadas approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@AlexandraLivadas AlexandraLivadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I refreshed raisinbread with the changes and everything works locally. Unit and integration tests also passed locally. @driusan This is ready for your review!

@driusan driusan merged commit d8dbb2e into aces:main Aug 3, 2022
@driusan
Copy link
Collaborator

driusan commented Aug 3, 2022

Thanks @AlexandraLivadas!

@kongtiaowang when you get back from vacation can you respond to @christinerogers's question?

@ridz1208 ridz1208 added this to the 25.0.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandraLivadas AlexandraLivadas AlexandraLivadas approved these changes

Assignees
No one assigned
Labels
RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kongtiaowang @christinerogers @driusan @AlexandraLivadas @ridz1208