New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EEG] Database Architecture for HED Tags #8036

Merged

driusan merged 7 commits into aces:main from jesscall:2022_03_03_HED_Tag_DB_Architecture

Jun 28, 2022

Contributor

jesscall commented Mar 3, 2022 •

edited

Loading

Brief summary of changes

This PR contains the necessary changes for adding HED Tag support to the database.

There is a single use script that should be run to archive the events files.

❗ Blocked ❗
Necessary changes will also have to be made to the LORIS-MRI code. PR #769

Testing instructions (if applicable)

Try to source the schema / run patch.
Run script in this PR to archive the events. cd tools/single_use/ && php archive_eeg_event_files.php
Make sure EEG Browser download links for event files still works.


          DB tables for HED Tags

8cbc947

jesscall added the State: Blocked label


          viz bugfixes events file access

82112f4

jesscall mentioned this pull request

[EEG-BIDS] Add support for events.json file & HED Tags aces/Loris-MRI#768

Closed

jesscall commented

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/0000-00-05-ElectrophysiologyTables.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/0000-00-05-ElectrophysiologyTables.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/0000-00-05-ElectrophysiologyTables.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/0000-00-05-ElectrophysiologyTables.sql Outdated Show resolved Hide resolved


          make param description nullable

0d6cef9

jesscall mentioned this pull request

[EEG-BIDS] Add support for events.json file & HED Tags aces/Loris-MRI#769

Merged

jesscall commented

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved

jesscall commented

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved


          move AssembledHED to physiological_task_event

aa07a6d

cmadjar requested changes

View reviewed changes

SQL/New_patches/2022-03-03-AddHEDTags.sql Outdated Show resolved Hide resolved

modules/electrophysiology_browser/php/sessions.class.inc Outdated Show resolved Hide resolved

tools/single_use/archive_eeg_event_files.php Show resolved Hide resolved

jesscall and others added 3 commits

June 14, 2022 11:38


          phpcs

19d70cb


          use ImagingFileTypes table

cc07a82


          use ImagingFileTypes for physio event files

1d83aca

cmadjar approved these changes

View reviewed changes

Collaborator

cmadjar left a comment

Looks good 👍

driusan merged commit e781689 into aces:main

kongtiaowang mentioned this pull request

[RaisinBread] main branch - fix gitactions frozen - add physiological_* data for integration test #8142

Merged

christinerogers removed the State: Blocked label

ridz1208 added this to the 25.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet