Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDB_BVL_Instrument] Add null value to examiner array #7847

Conversation

CamilleBeau
Copy link
Contributor

Brief summary of changes

This PR adds an empty value to the array of examiner names. This was mistakenly taken out in #7462, and is causing the first value to be selected by default in instruments.

Testing instructions (if applicable)

  1. Check that there is an empty option in the examiner drop down of instruments, and make sure that no value is selected by default.

@ridz1208
Copy link
Collaborator

@CamilleBeau any reason or effect that the removed code was array(''=>'') and you are adding [null=>''] ?

@CamilleBeau
Copy link
Contributor Author

@CamilleBeau any reason or effect that the removed code was array(''=>'') and you are adding [null=>''] ?

There is no reason. I just put null => '' because that's what we usually do in instruments on CCNA.

@driusan driusan merged commit 6c30b1c into aces:23.0-release Nov 24, 2021
@ridz1208 ridz1208 added this to the 23.0.10 milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants