[user_accounts] Use userID to update examiners table

[CamilleBeau]

Brief summary of changes

Currently when updating the examiners table in edit_user, it is assumed that a unique examiner exists based on their full name instead of their userID. This causes 2 problems:

• If an examiner with the same name as another examiner is edited, the older one will be replaced in the table and will no longer be considered an examiner. I.e. only one examiner can exist per full name.
• If a user's name is edited, then a new row will be created in the examiners table and there will be 2 rows for the same user.

This PR fixes this issue by assuming in the user_accounts module that examiners have a unique userID instead of assuming examiners have a unique full name in the user accounts module.

However, since examiners do not have to be users, the examiners module was edited to assume that an examiner added is not a user. The examiner module does not ask for any identifying info other than the full name, so it would be impossible to know which user is being referred to if we are accepting that different users may exist with the same name.

The resulting implementation is that only one non-user examiner can be added per full name, but any LORIS users that are added as examiners do not have to have a unique name.

The instrument library file is also edited to add an email beside the full name in the examiners list examiners with duplicate names.

Included in this PR is a cleanup script that gets rid of the duplicate userIDs in the examiner table which were added because of a name change in "edit user".

A script was not made for adding back examiners that may have been overwritten by a new user with the same name, because there is no way to determine this based on the previous implementation of examiners.

Testing instructions (if applicable)

1.Request an account and select "Examiner role"
2. check that a row in the examiners table exists for this newly requested user
3. From user_accounts, edit this user to change the name.
4. Check that the full name is updated in the examiners table for that user, and that only one row exists for that userID
5. Create an account for a user with the same name as an already-existing examiner
6. Make sure that a new row with a different userID is created in the examiners table. Both the older user and the newer user should have rows in the examiner table.
7. Test the examiners module according to the module testing instructions
8. Make sure that duplicate names in the examiner drop down of an instrument are identified with an email (if one of the names is from a non-user examiner, there will be no email next to that one)
9. From outside of this PR, change the name of a user with examiner credentials. Check that they exist twice in the examiners table (once with old name, once with new name)
10. From inside this PR, run the Remove_duplicate_examiners.php script. Make sure that it gets rid of the duplicate examiner with the old name in the examiners table.
11. Make sure that examinerIDs are updated appropriately in the certification table.
12. Make sure that rows are removed from the examiners_psc_rel table.
13. Make sure that no rows are deleted/updated for the correct examinerID

Link(s) to related issue(s)

• [user_accounts] Examiners with same name removed from table #6973

[driusan]

@jesscall maybe you can review?

[jesscall]

Looks good, just waiting for a cleanup script to be written

[jesscall]

@CamilleBeau let me know when this is ready for re-rview

[CamilleBeau]

@jesscall Ready for review!

[racostas]

Step 5. "Create an account for a user with the same name as an already-existing examiner" isn't working for me, got 500 error. (I'm crating the account as Admin->add User).

[CamilleBeau]

@racostas I couldn't replicate this error. I was able to request an account for a user who had the same name (mine for testing) as 2 other users in the DB. You were testing this on CCNA data right? The login module has an override on CCNA

[racostas]

@racostas I couldn't replicate this error. I was able to request an account for a user who had the same name (mine for testing) as 2 other users in the DB. You were testing this on CCNA data right? The login module has an override on CCNA

Strange. I would suggest somebody else to test. I tested in a fresh version of Loris 23.0.3 using RB not in CCNA but could have some missconfig. Steps from 1 to 4 worked fine nevertheless.

[CamilleBeau]

Strange. I would suggest somebody else to test. I tested in a fresh version of Loris 23.0.3 using RB not in CCNA but could have some missconfig. Steps from 1 to 4 worked fine nevertheless.

I was able to replicate the error Rolando found after all, and I have committed a fix. Ready for re-testing @racostas

[racostas]

LGTM now.

[ridz1208]

before SQL