Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON data toolkit #6748

Closed
wants to merge 3 commits into from
Closed

JSON data toolkit #6748

wants to merge 3 commits into from

Conversation

CamilleBeau
Copy link
Contributor

@CamilleBeau CamilleBeau commented Jun 18, 2020 •
edited
Loading

This PR creates a toolkit for manipulating and interacting with instrument JSON data, intended for future instruments that will not have their own SQL tables.
Operations include:

  • Renaming fields
  • Dropping fields
  • Selecting specified data
  • Modifying fields

This includes a library with functions to interact with the instrument data as well as a tools script to perform operations directly.

Needs work:

@CamilleBeau CamilleBeau added the State: Needs work PR awaiting additional work by the author to proceed label Jun 18, 2020
@ridz1208
Copy link
Collaborator

@CamilleBeau

functionality blocked until issue #6746 is solved as it prevents saving for modification of instruments that have already been set to complete.

Instruments set to complete should not be saved. is the bug only for completed instruments ?

@CamilleBeau
Copy link
Contributor Author

@CamilleBeau

functionality blocked until issue #6746 is solved as it prevents saving for modification of instruments that have already been set to complete.

Instruments set to complete should not be saved. is the bug only for completed instruments ?

Also instruments that have had one page (for example) saved but are not yet set to complete.

@ridz1208
Copy link
Collaborator

@CamilleBeau maybe modify the description its a bit confusing. its basically any instrument that has been started

@CamilleBeau
Copy link
Contributor Author

@CamilleBeau maybe modify the description its a bit confusing. its basically any instrument that has been started

Yes my bad!

@ridz1208
Copy link
Collaborator

@CamilleBeau can you make sure it passes travis and conflicts are fixed ?

@CamilleBeau CamilleBeau added the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Jul 13, 2020
@CamilleBeau CamilleBeau force-pushed the 2020_06_18_JSON_Data_Toolkit branch from 549dea7 to c0c3896 Compare July 21, 2020 16:46
@CamilleBeau CamilleBeau changed the base branch from master to main July 21, 2020 16:46
@ridz1208 ridz1208 self-assigned this Aug 4, 2020
@CamilleBeau
Copy link
Contributor Author

Blocked by #6876

@ridz1208 ridz1208 removed their assignment Jun 14, 2021
@cmadjar cmadjar removed the State: Blocked PR or issue awaiting an external event such as the merge or another PR to proceed label Nov 29, 2022
@CamilleBeau
Copy link
Contributor Author

Closing this PR as most functionalities intended to be introduced from this PR will be possible with MariaDB JSON

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ridz1208 ridz1208

Labels
State: Needs work PR awaiting additional work by the author to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CamilleBeau @ridz1208 @cmadjar