Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistaken field created in _nullStatus function of NDB_BVL_Instrument #6746

Closed
CamilleBeau opened this issue Jun 17, 2020 · 0 comments · Fixed by #6876
Closed

Mistaken field created in _nullStatus function of NDB_BVL_Instrument #6746

CamilleBeau opened this issue Jun 17, 2020 · 0 comments · Fixed by #6876
Labels
Category: Bug PR or issue that aims to report or fix a bug

Comments

@CamilleBeau
Copy link
Contributor

Describe the bug
The function _nullStatus in NDB_BVL_Instrument class checks for fields ending with _status having set values, and sets their corresponding fields without _status to null. An array of data from flag often includes the field Data_entry_completion_status. When passing this array through _saveValues function to save, this results in a mistake where a new field Data_entry_completion is created and set to null.

A possible solution to this would be to move the Data_entry_completion_status field into its own column in the flag table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant