Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missileguidance - fix MCLOS direction error #10813

Merged
merged 4 commits into from
Mar 20, 2025
Merged

missileguidance - fix MCLOS direction error #10813

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c07ca30
fix MCLOS direction error
TheCandianVendingMachine Mar 18, 2025
fa53b47
update comment
TheCandianVendingMachine Mar 18, 2025
b2c7d4d
change setting names
TheCandianVendingMachine Mar 19, 2025
2173f79
change keybind name for future needs
TheCandianVendingMachine Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions addons/missileguidance/XEH_postInit.sqf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@
[DIK_NUMPAD2, [false, false, false]], false, 0] call CBA_fnc_addKeybind; // Numpad 2

["ACE3 Weapons", QGVAR(mclosLeft), LLSTRING(mclosLeft), {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["ACE3 Weapons", QGVAR(mclosLeft), LLSTRING(mclosLeft), {
["ACE3 Weapons", QGVAR(mclos_Left), LLSTRING(mclosLeft), {

this is clunky but i think nessacary

the first time a keybind is added, the default binding gets added to the user profile and will stay that way
even if the default bind changes

so the only way to fix is to change the naming-key
otherwise everyone who played with have backward keys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well thats not ideal. since people are already saying how they rebound the controls to other keys, wouldn't this split their control scheme? I think that reversing direction is going to be more wanted than just losing control completely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to just rename all 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to add a keybind but not have it be rebindable? I would rather keep these bad names and have them mapped as expected, but then add the correct ones as well

[[1, 0, 0], ACE_player] call FUNC(MCLOS_buttonPressed)
}, {
[[-1, 0, 0], ACE_player] call FUNC(MCLOS_buttonPressed)
}, {
[[1, 0, 0], ACE_player] call FUNC(MCLOS_buttonPressed)
},
[DIK_NUMPAD6, [false, false, false]], false, 0] call CBA_fnc_addKeybind; // Numpad 6
[DIK_NUMPAD4, [false, false, false]], false, 0] call CBA_fnc_addKeybind; // Numpad 4

["ACE3 Weapons", QGVAR(mclosRight), LLSTRING(mclosRight), {
[[-1, 0, 0], ACE_player] call FUNC(MCLOS_buttonPressed)
}, {
[[1, 0, 0], ACE_player] call FUNC(MCLOS_buttonPressed)
}, {
[[-1, 0, 0], ACE_player] call FUNC(MCLOS_buttonPressed)
},
[DIK_NUMPAD4, [false, false, false]], false, 0] call CBA_fnc_addKeybind; // Numpad 4
[DIK_NUMPAD6, [false, false, false]], false, 0] call CBA_fnc_addKeybind; // Numpad 6

if (!hasInterface) exitWith {};

Expand Down