-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missileguidance - fix MCLOS direction error #10813
Conversation
@@ -24,18 +24,18 @@ | |||
[DIK_NUMPAD2, [false, false, false]], false, 0] call CBA_fnc_addKeybind; // Numpad 2 | |||
|
|||
["ACE3 Weapons", QGVAR(mclosLeft), LLSTRING(mclosLeft), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["ACE3 Weapons", QGVAR(mclosLeft), LLSTRING(mclosLeft), { | |
["ACE3 Weapons", QGVAR(mclos_Left), LLSTRING(mclosLeft), { |
this is clunky but i think nessacary
the first time a keybind is added, the default binding gets added to the user profile and will stay that way
even if the default bind changes
so the only way to fix is to change the naming-key
otherwise everyone who played with have backward keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well thats not ideal. since people are already saying how they rebound the controls to other keys, wouldn't this split their control scheme? I think that reversing direction is going to be more wanted than just losing control completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably best to just rename all 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way to add a keybind but not have it be rebindable? I would rather keep these bad names and have them mapped as expected, but then add the correct ones as well
sorry, just though of this now all we have to do right now is change the name |
I'm keeping the strings the way they are right now, they can be changed in the Spike PR |
When merged this pull request will:
The controls were named wrong. The comments changed show that left was always bound to right, and vice versa.
Strictly speaking, not tested in game. But this is realistically the only path which this got changed so it should work - hopefully.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.