Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missileguidance - fix MCLOS direction error #10813

Merged
merged 4 commits into from
Mar 20, 2025
Merged

missileguidance - fix MCLOS direction error #10813

merged 4 commits into from
Mar 20, 2025

Conversation

TheCandianVendingMachine
Copy link
Contributor

When merged this pull request will:

  • Fix MCLOS direction error

The controls were named wrong. The comments changed show that left was always bound to right, and vice versa.

Strictly speaking, not tested in game. But this is realistically the only path which this got changed so it should work - hopefully.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@TheCandianVendingMachine TheCandianVendingMachine added the kind/bug-fix Release Notes: **FIXED:** label Mar 18, 2025
@TheCandianVendingMachine TheCandianVendingMachine added this to the 3.19.2 milestone Mar 18, 2025
@@ -24,18 +24,18 @@
[DIK_NUMPAD2, [false, false, false]], false, 0] call CBA_fnc_addKeybind; // Numpad 2

["ACE3 Weapons", QGVAR(mclosLeft), LLSTRING(mclosLeft), {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["ACE3 Weapons", QGVAR(mclosLeft), LLSTRING(mclosLeft), {
["ACE3 Weapons", QGVAR(mclos_Left), LLSTRING(mclosLeft), {

this is clunky but i think nessacary

the first time a keybind is added, the default binding gets added to the user profile and will stay that way
even if the default bind changes

so the only way to fix is to change the naming-key
otherwise everyone who played with have backward keys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well thats not ideal. since people are already saying how they rebound the controls to other keys, wouldn't this split their control scheme? I think that reversing direction is going to be more wanted than just losing control completely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably best to just rename all 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way to add a keybind but not have it be rebindable? I would rather keep these bad names and have them mapped as expected, but then add the correct ones as well

@PabstMirror
Copy link
Contributor

sorry, just though of this now
should we make a unified missileguidance_adjustLeft key
and use the same key for both mclos and spike?

all we have to do right now is change the name
and can handle the code change in spike pr

@TheCandianVendingMachine
Copy link
Contributor Author

I'm keeping the strings the way they are right now, they can be changed in the Spike PR

@PabstMirror PabstMirror merged commit 6146d5a into master Mar 20, 2025
3 checks passed
@PabstMirror PabstMirror deleted the mclos_fix branch March 20, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants