Feature Request: Support the syncing of individual business shared files

[justinabrahms]

Hi. Me from #1294 which got closed (whew! Quick turn around!)

Even if I create a file at ~/.config/onedrive/sync_list with my file name in it, it never gets pulled down.

I've tried this command:

onedrive --synchronize -v --resync 

The file I want is still seemingly excluded:

WARNING: Not syncing this OneDrive Business Shared File: File I Want.xlsx
OneDrive Business Shared File - Shared By:  Person ([email protected])

I want the file. It's not syncing. Even if I specify * as the entry in sync_list.

As best I can tell, it's being excluded in this line of code:

onedrive/src/sync.d

Line 719 in 3ea16b6

// log that this is not supported

This isn't the only file that's being excluded either. There are several.

WARNING: Not syncing this OneDrive Business Shared File: Tomato Press release_101519_cc.docx
OneDrive Business Shared File - Shared By:  Person1 ([email protected])
WARNING: Not syncing this OneDrive Business Shared File: Consolidated KPIs.pptx
OneDrive Business Shared File - Shared By:  Person2 ([email protected])
WARNING: Not syncing this OneDrive Business Shared File: Prework.pptx
OneDrive Business Shared File - Shared By:  Person3 ([email protected])

The only commonality seems to be that they are docs shared with me and they have spaces in the name.

[abraunegg]

@justinabrahms
The issue here is that the "Shared Business Folders" feature, is just that - for syncing business shared folders, shared with you - not individual files that have been shared with you.

Now why do you get this:

WARNING: Not syncing this OneDrive Business Shared File: Tomato Press release_101519_cc.docx
OneDrive Business Shared File - Shared By:  Person1 ([email protected])
WARNING: Not syncing this OneDrive Business Shared File: Consolidated KPIs.pptx
OneDrive Business Shared File - Shared By:  Person2 ([email protected])
WARNING: Not syncing this OneDrive Business Shared File: Prework.pptx
OneDrive Business Shared File - Shared By:  Person3 ([email protected])

This is because the 'SharedWithMe' API call returns all items shared. This client, because of the current feature, excludes files because of the way that this feature is implemented. Files were excluded because of pattern matching issues between various elements, and, to keep the feature in part in-sync with Personal Shared Folders.

Is there anyway to have the user share a specific folder with you - and you sync that folder rather than an individual file?

The only real way to support syncing business shared individual files at present would be to re-write the entire feature so that they are correctly supported with pattern matching between file / folder designations. This would also require a complete re-write of how the folders are stored and represented locally. This would also open up a whole host of other questions & issues - if you have a list of files, and someone shares that file with you, with the same name as someone else, what happens - conflict? overwrite? fail? something else?

Additionally, the OneDrive API (and Azure AD) is, at present, broken for when a file or folder is shared with you, from someone external to your organisation. The authentication process becomes null, thus, you cannot access the file or folder - until MS fix the API / Azure AD - that cannot be supported (see: #966)

[justinabrahms]

Thanks, abraunegg. Your reasoning makes sense. My intent was a "hey, I want this feature please". I still want the feature, even if it's a pain. That said, if you wanna WONTFIX it, that's cool too. Thanks for building the tool. :)

[abraunegg]

@justinabrahms , @AnthonyAnkrah

Firstly I apologise for this response is a long time in coming - however this Feature Request has now been completed.

Important: Before you do anything else ... please first read the updated documentation for OneDrive Business Shared Items: https://github.com/abraunegg/onedrive/blob/Implement-Feature-Request-1300/docs/business-shared-items.md

The entire feature has been re-written, how it is implemented has been changed - hopefully the documentation is clear enough on how to configure this feature going forward.

If you want to test the PR, please use the instructions below:

git clone https://github.com/abraunegg/onedrive.git
cd onedrive
git fetch origin pull/2646/head:pr2646
git checkout pr2646

All feedback - positive or negative (or something else) is highly appreciated.

To run the PR, you need to run the client from the PR build directory:

./onedrive <any options needed>

To install the PR, you will need to perform sudo make install to install the PR version.

When running the PR, your version should be: v2.5.0-alpha-5 GitHub version: v2.4.25-93-gfde6f86 or greater

[abraunegg]

@justinabrahms , @AnthonyAnkrah

Additionally, I want to roll this into 'alpha-5' , then create a 'beta' release :) so this is potentially the last major feature change before a v2.5.0 release.

All feedback , good or bad is highly welcome.

[abraunegg]

Closing this as code has been merged into 'alpha-5' to allow continued work to progress 'alpha-5' to 'beta' status.

[abraunegg]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.