API Bug: OneDrive Business Shared Folders: Unable to sync shared folders, shared from outside organisation

[abraunegg]

Shared folders, shared with you from people outside of your 'organisation' are unable to be synced. This is due to the Microsoft Graph API not presenting these folders.

Shared folders that match this scenario, when you view 'Shared' via OneDrive online, will have a 'world' symbol as per below:

This can only be fixed once the Microsoft Graph API is fixed.

[abraunegg]

Opened API Issue: OneDrive/onedrive-api-docs#1301

[abraunegg]

Also commented here: https://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/7858

[mickaelleclercq]

The issue seem to remain.
I have folder shared from external organization that I can see in the browser, but onedrive --list-shared-folders cannot

[abraunegg]

@mickaelleclercq

The issue seem to remain.
I have folder shared from external organization that I can see in the browser, but onedrive --list-shared-folders cannot

This is a known issue, hence why I opened this issue ticket to tracking and visibility. This is also why it is listed as a known issue here: https://github.com/abraunegg/onedrive/blob/master/docs/BusinessSharedFolders.md#known-issues

The 'master' codebase does not have the required fix to handle external organisation shared folders, although there is a PR which contains a potential fix.

To assist with testing the current fix, please can you test the following PR which may resolve the issue, however in my testing the OneDrive API issue still exists - as in, whilst shared folders are now listed, accessing / syncing them fails as the OneDrive API does not authorise the access correctly. This could be, for my case, due to using a 'developer' Business account + shared folder from a commercial organisation. The API failure might be legitimate in this case.

Please test the following PR in your situation:

git clone https://github.com/abraunegg/onedrive.git
cd onedrive
git fetch origin pull/969/head:pr969
git checkout pr969
./configure; make clean; make;

When running the PR, your version should be: onedrive v2.4.8-28-g2a93b4e or greater.

This is a work-in-progress (WIP) branch. It may contain other defects and needs extensive testing. Use with caution.

[mickaelleclercq]

After what you propose, I ended with the very last version:

$ onedrive --version onedrive v2.4.8-28-g2a93b4e

Now I have this error. With the previous version I had no results, so it there is improvement !

$onedrive --list-shared-folders
Configuration file successfully loaded
Configuring Global Azure AD Endpoints
Initializing the Synchronization Engine ...

Listing available OneDrive Business Shared Folders:
onedrive.OneDriveException@src/onedrive.d(1464): HTTP request returned status code 403 (Forbidden)
{
    "error": {
        "code": "Authorization_RequestDenied",
        "innerError": {
            "client-request-id": "a9cb5512-ea4d-40b3-9688-bf1b59bb635b",
            "date": "2020-12-11T21:11:13",
            "request-id": "a9cb5512-ea4d-40b3-9688-bf1b59bb635b"
        },
        "message": "Insufficient privileges to complete the operation."
    }
}
----------------
??:? void onedrive.OneDriveApi.checkHttpCode(ref const(std.json.JSONValue)) [0x564db2654678]
??:? std.json.JSONValue onedrive.OneDriveApi.get(const(char)[], bool) [0x564db2652b0b]
??:? std.json.JSONValue onedrive.OneDriveApi.getTenantID() [0x564db2650648]
??:? void sync.SyncEngine.listOneDriveBusinessSharedFolders() [0x564db2674e6f]
??:? _Dmain [0x564db26498d3]
std.net.curl.CurlException@std/net/curl.d(4402): A libcurl function was given a bad argument on handle null
----------------
??:? pure @safe void std.exception.bailOut!(std.net.curl.CurlException).bailOut(immutable(char)[], ulong, scope const(char)[]) [0x564db26e4086]
??:? pure @safe bool std.exception.enforce!(std.net.curl.CurlException).enforce!(bool).enforce(bool, lazy const(char)[], immutable(char)[], ulong) [0x564db26e3ff7]
??:? void std.net.curl.Curl._check(int) [0x564db26b38cb]
??:? void std.net.curl.Curl.clear(etc.c.curl.CurlOption) [0x564db26b3c76]
??:? void std.net.curl.HTTP.clearRequestHeaders() [0x564db26b29ab]
??:? void onedrive.OneDriveApi.shutdown() [0x564db264f5ec]

[mickaelleclercq]

Note that onedrive --synchronize --dry-run works like a charm, so the privileges are working normally for the non-shared content

[abraunegg]

@mickaelleclercq
For this command onedrive --list-shared-folders - please provide a verbose debug log as per the support requirements: https://github.com/abraunegg/onedrive/wiki/Generate-debug-log-for-support