Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined UX including consistent scrollbars, tooltips, Search in licenses, filters for dependencies #587

Merged
merged 10 commits into from
Jul 28, 2023

Conversation

OmkarPh
Copy link
Collaborator

@OmkarPh OmkarPh commented Jul 10, 2023

Fixes #574

Signed-off-by: Omkar Phansopkar <[email protected]>
@OmkarPh OmkarPh changed the title Refined UX including scrolling, tooltips, lists, filters based on feedbacks Refined UX including consistent scrollbars, tooltips, Search in licenses, filters for dependencies Jul 22, 2023
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmkarPh LGTM!

Thanks for the UX updates. Looks great!
Thanks also for the misc fixes, they're resolving the issues too, except the scroll to file in case of deeply nested/large directories, which is minor and can be handled separately.

ux_update_1

ux_update_2

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny nits for your consideration (looks ready to merge and release otherwise):

  1. in the package-dependency explorer do you think it would be nicer to use PackageURLs all the way, i.e.
    instead of maven/org.elasticsearch.plugin/[email protected] use: pkg:maven/org.elasticsearch.plugin/[email protected] on the left package selectors.

This takes a bit more space for all PURLs but is more consistent.

  1. Also do you think it's worthwhile to update the default width of the left pane more on the package-dependency explorer to be at least equal to the right pane for details (or even more?) as the PURLs usually are overflowed to the next line, but on the right there is plenty of free space. I usually always increase the size myself for viewing so considering if this should be default.

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Jul 28, 2023

Thanks for the UX updates. Looks great! Thanks also for the misc fixes, they're resolving the issues too, except the scroll to file in case of deeply nested/large directories, which is minor and can be handled separately.

Yep, I've created #590 to track this

Two tiny nits for your consideration (looks ready to merge and release otherwise):

  1. in the package-dependency explorer do you think it would be nicer to use PackageURLs all the way, i.e.
    instead of maven/org.elasticsearch.plugin/[email protected] use: pkg:maven/org.elasticsearch.plugin/[email protected] on the left package selectors.

This takes a bit more space for all PURLs but is more consistent.

Yep, I think that's more consistent

  1. Also do you think it's worthwhile to update the default width of the left pane more on the package-dependency explorer to be at least equal to the right pane for details (or even more?) as the PURLs usually are overflowed to the next line, but on the right there is plenty of free space. I usually always increase the size myself for viewing so considering if this should be default.

Unlike other explorers, there isn't much on the right pane here, I think 50% should be ideal for now
Later we can see what's comfortable for others after the review

Also, note that we have an experimental table of dependencies in packages explorer on the right pane in experiment/dependenciesViews If we go ahead with it, we might want to reconsider this width
That's going to be after the RC release, so we'll track it in it's own PR

@OmkarPh OmkarPh merged commit c8c04d8 into v4.0-react-typescript Jul 28, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the improve/styling-feedbacks branch October 25, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve search for license expressions in License Detections Explorer dashboard
2 participants