-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refined UX including consistent scrollbars, tooltips, Search in licenses, filters for dependencies #587
Conversation
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
…ove/styling-feedbacks
Signed-off-by: Omkar Phansopkar <[email protected]>
Signed-off-by: Omkar Phansopkar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmkarPh LGTM!
Thanks for the UX updates. Looks great!
Thanks also for the misc fixes, they're resolving the issues too, except the scroll to file in case of deeply nested/large directories, which is minor and can be handled separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny nits for your consideration (looks ready to merge and release otherwise):
- in the package-dependency explorer do you think it would be nicer to use PackageURLs all the way, i.e.
instead ofmaven/org.elasticsearch.plugin/[email protected]
use:pkg:maven/org.elasticsearch.plugin/[email protected]
on the left package selectors.
This takes a bit more space for all PURLs but is more consistent.
- Also do you think it's worthwhile to update the default width of the left pane more on the package-dependency explorer to be at least equal to the right pane for details (or even more?) as the PURLs usually are overflowed to the next line, but on the right there is plenty of free space. I usually always increase the size myself for viewing so considering if this should be default.
Yep, I've created #590 to track this
Yep, I think that's more consistent
Unlike other explorers, there isn't much on the right pane here, I think 50% should be ideal for now Also, note that we have an experimental table of dependencies in packages explorer on the right pane in experiment/dependenciesViews If we go ahead with it, we might want to reconsider this width |
…kages list width Signed-off-by: Omkar Phansopkar <[email protected]>
Fixes #574