Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search for license expressions in License Detections Explorer dashboard #574

Closed
mjherzog opened this issue May 29, 2023 · 7 comments · Fixed by #587
Closed

Improve search for license expressions in License Detections Explorer dashboard #574

mjherzog opened this issue May 29, 2023 · 7 comments · Fixed by #587
Assignees

Comments

@mjherzog
Copy link
Member

I am running SCWB v4.0.0.rc3 on Windows.

When you access the License Detections Explorer dashboard there is no obvious order for the list of license-expressions. It is definitely not alpha order or number of detections. This should be an alpha order default so at least you can intelligently scroll to find what you are looking for. It would be even better to have a search option for the list.

This improvement would be generally very useful and there is the more specific use case where you are looking for a pattern in a license detection that applies to multiple files.

@mjherzog
Copy link
Member Author

@johnmhoran I assigned to you for review of the problem/solution statement

@johnmhoran
Copy link
Member

Thanks @mjherzog . This looks good. Alpha order would also make it easier for the user to keep track of his or her review progress.

@OmkarPh
Copy link
Collaborator

OmkarPh commented Jun 2, 2023

what do we exactly mean by 'alpha order' here?

@mjherzog
Copy link
Member Author

mjherzog commented Jun 2, 2023

I mean alphabetic order for the license expression so apache-2.0 before gpl-2.0. I was guessing that we could treat the license expression as a string and use that to sort in alphabetic order.

@OmkarPh
Copy link
Collaborator

OmkarPh commented Jun 2, 2023

got it

@AyanSinhaMahapatra
Copy link
Member

Note that the alphabetical sorting order is also being implemented directly at scancode-toolkit top level license detections at: aboutcode-org/scancode-toolkit@3706744 as it made more sense there too (and this will be propagated elsewhere too). So this need not be implemented again here in SCWB.

It would be even better to have a search option for the list.

Keeping the issue open for this part ^

@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Improve sort / search for license expressions in License Detections Explorer dashboard Improve search for license expressions in License Detections Explorer dashboard Jun 23, 2023
@OmkarPh
Copy link
Collaborator

OmkarPh commented Jul 19, 2023

Fixed a Bug in latest commit - Letter cases weren't handled correctly, For example searching for or didn't display entries with OR

@OmkarPh OmkarPh closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants