-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search for license expressions in License Detections Explorer dashboard #574
Comments
@johnmhoran I assigned to you for review of the problem/solution statement |
Thanks @mjherzog . This looks good. Alpha order would also make it easier for the user to keep track of his or her review progress. |
what do we exactly mean by 'alpha order' here? |
I mean alphabetic order for the license expression so apache-2.0 before gpl-2.0. I was guessing that we could treat the license expression as a string and use that to sort in alphabetic order. |
got it |
Note that the alphabetical sorting order is also being implemented directly at scancode-toolkit top level license detections at: aboutcode-org/scancode-toolkit@3706744 as it made more sense there too (and this will be propagated elsewhere too). So this need not be implemented again here in SCWB.
Keeping the issue open for this part ^ |
Fixed a Bug in latest commit - Letter cases weren't handled correctly, For example searching for |
I am running SCWB v4.0.0.rc3 on Windows.
When you access the License Detections Explorer dashboard there is no obvious order for the list of license-expressions. It is definitely not alpha order or number of detections. This should be an alpha order default so at least you can intelligently scroll to find what you are looking for. It would be even better to have a search option for the list.
This improvement would be generally very useful and there is the more specific use case where you are looking for a pattern in a license detection that applies to multiple files.
The text was updated successfully, but these errors were encountered: