Skip to content

Fix undefined parsing error on languages missing from call routers #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magyargergo merged 4 commits into from
Mar 18, 2026
Merged

Fix undefined parsing error on languages missing from call routers #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a4ece5
fix: mapping all supported languages to callRouters to fix undefined …
demirciberk Mar 18, 2026
fbf3f24
fix(cli): remove duplicate Swift/Kotlin keys in callRouters causing T…
demirciberk Mar 18, 2026
7165d0f
refactor: remove runtime callRouter fallbacks, rely on Record<Support…
demirciberk Mar 18, 2026
8c35cd3
refactor: use 'satisfies' keyword for callRouters compile-time enforc…
demirciberk Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gitnexus-web/src/config/supported-languages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@ export enum SupportedLanguages {
Rust = 'rust',
PHP = 'php',
Ruby = 'ruby',
Kotlin = 'kotlin',
Comment thread
magyargergo marked this conversation as resolved.
Swift = 'swift',
}
5 changes: 3 additions & 2 deletions gitnexus-web/src/core/ingestion/call-routing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type CallRouter = (
const noRouting: CallRouter = () => null;

/** Per-language call routing. noRouting = no special routing (normal call processing) */
export const callRouters: Record<SupportedLanguages, CallRouter> = {
export const callRouters = {
[SupportedLanguages.JavaScript]: noRouting,
[SupportedLanguages.TypeScript]: noRouting,
[SupportedLanguages.Python]: noRouting,
Expand All @@ -40,7 +40,8 @@ export const callRouters: Record<SupportedLanguages, CallRouter> = {
[SupportedLanguages.CPlusPlus]: noRouting,
[SupportedLanguages.C]: noRouting,
[SupportedLanguages.Ruby]: routeRubyCall,
};
[SupportedLanguages.Kotlin]: noRouting,
} satisfies Record<SupportedLanguages, CallRouter>;

// ── Result types ────────────────────────────────────────────────────────────

Expand Down
4 changes: 2 additions & 2 deletions gitnexus/src/core/ingestion/call-routing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export type CallRouter = (
const noRouting: CallRouter = () => null;

/** Per-language call routing. noRouting = no special routing (normal call processing) */
export const callRouters: Record<SupportedLanguages, CallRouter> = {
export const callRouters = {
[SupportedLanguages.JavaScript]: noRouting,
[SupportedLanguages.TypeScript]: noRouting,
[SupportedLanguages.Python]: noRouting,
Expand All @@ -41,7 +41,7 @@ export const callRouters: Record<SupportedLanguages, CallRouter> = {
[SupportedLanguages.CPlusPlus]: noRouting,
[SupportedLanguages.C]: noRouting,
[SupportedLanguages.Ruby]: routeRubyCall,
};
} satisfies Record<SupportedLanguages, CallRouter>;

// ── Result types ────────────────────────────────────────────────────────────

Expand Down
Loading