Fix undefined parsing error on languages missing from call routers#364
Merged
Conversation
|
@demirciberk is attempting to deploy a commit to the NexusCore Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Can you fix this tsc error? |
Contributor
Author
|
I fixed it. Thanks. |
magyargergo
requested changes
Mar 18, 2026
…edLanguages> compile-time enforcement
magyargergo
approved these changes
Mar 18, 2026
Contributor
Author
|
Sorry for the inconvention. Is it OK now? |
Contributor
CI Report✅ All checks passed Pipeline Status
Test Results
✅ All 2687 tests passed 20 test(s) skipped — expand for detailsIntegration:
Unit:
Code CoverageCombined (Unit + Integration)
Coverage breakdown by test suiteUnit Tests
Integration Tests
📋 View full run · Generated by CI |
Collaborator
|
Thank you for your contribution! |
motolese
pushed a commit
to motolese/datamoto-gitnexus
that referenced
this pull request
Apr 23, 2026
…bhigyanpatwari#364) * fix: mapping all supported languages to callRouters to fix undefined apply error (abhigyanpatwari#352) * fix(cli): remove duplicate Swift/Kotlin keys in callRouters causing TS1117 * refactor: remove runtime callRouter fallbacks, rely on Record<SupportedLanguages> compile-time enforcement * refactor: use 'satisfies' keyword for callRouters compile-time enforcement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #352 ("Cannot read properties of undefined (reading 'apply')").
The root cause was that newer languages like Kotlin (used heavily in the Lynx repository referenced in the issue) were added to the
SupportedLanguagesenum but omitted from the CLI and Web parsingcallRoutersmappings. When the parser encountered a Kotlin file, it accessed an undefined call router, crashing the process.This PR adds the missing languages mapping to both CLI and Web
callRoutersimplementations and embeds a genericnoRoutingfallback handler for additional safety. Impact analysis confirms this has zero negative blast radius.