Skip to content

Static deserializer builder needed the default maximum recursion #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdwardCooke merged 1 commit into from
Jun 22, 2026
Merged

Static deserializer builder needed the default maximum recursion #1111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions YamlDotNet/Serialization/StaticDeserializerBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ public StaticDeserializerBuilder(StaticContext context)
{ typeof(PreventUnknownTagsNodeTypeResolver), _ => new PreventUnknownTagsNodeTypeResolver() },
{ typeof(DefaultContainersNodeTypeResolver), _ => new DefaultContainersNodeTypeResolver() }
};

maximumRecursion = 130;
Comment thread
EdwardCooke marked this conversation as resolved.
}

protected override StaticDeserializerBuilder Self { get { return this; } }
Expand Down Expand Up @@ -459,11 +461,16 @@ public IValueDeserializer BuildValueDeserializer()
}

/// <summary>
/// Sets the maximum recursion that is allowed while deserializing.
/// Sets the maximum recursion that is allowed while building the object graph. Must be > 0. Default is 130.
/// </summary>
/// <remarks>
/// Setting this limit is strongly recommended when parsing untrusted input since
/// deeply nested objects will lead to a stack overflow.
/// deeply nested objects will lead to a stack overflow. When using the default configuration
/// on Windows the maximum you should allow is ~130 as anything over that will lead to a stack overflow
/// when the max recursion exception is thrown. Linux OS allows for ~475 with .net 10 and the exception will be
Comment thread
EdwardCooke marked this conversation as resolved.
/// thrown correctly without causing a stack overflow. This does not take into account the depth of
/// your application call stack. This is if YamlDotNet is called from the top of the stack. Windows with
/// .NET 8 only allows for ~130. On .NET 10 and Windows you can safely use ~152.
/// </remarks>
public StaticDeserializerBuilder WithMaximumRecursion(int maximumRecursion)
{
Expand Down
Loading