Static deserializer builder needed the default maximum recursion#1111
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates StaticDeserializerBuilder so it matches the security-hardened default behavior of the reflection-based DeserializerBuilder by enabling a default maximum recursion limit during deserialization.
Changes:
- Set a default
maximumRecursionof130inStaticDeserializerBuilder’s constructor. - Update
WithMaximumRecursionXML documentation to describe the default and provide guidance about safe limits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jun 26, 2026
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome!
Needed to add the maximum recursion to the static deserializer builder to complete the security finding.