Improve ACP auth and origin defaults - #9886
Conversation
|
Documentation preview deployed: https://pr-9886.goose-pr-previews-poc.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab4acb3ca0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Approving — nice security hardening, and the tests genuinely exercise the origin/CORS behaviour. Confirmed the stdio path (goose acp) is untouched and still needs no secret, which is correct; the secret enforcement only applies to the network-exposed goose serve.
One thing worth addressing before merge (codex's P2 is right here): in the goosed path (crates/goose-server/src/commands/agent.rs) the merged app is still wrapped in an outer CorsLayer::new().allow_origin(Any). Since tower-http answers OPTIONS preflight at that outer layer before routing, the tightened ACP CORS defaults are effectively bypassed for goosed — arbitrary origins still get permissive CORS there. Could you either tighten that outer layer too or add a note on why it's out of scope for this PR?
4530d7b to
546bd99
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 546bd992ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
546bd99 to
4ae194f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ae194fa9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4ae194f to
49a6b25
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49a6b25dfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
49a6b25 to
dc37602
Compare
3 participants
goose servestartup with no secret key defined, unless--dangerously-unauthenticatedis passed--allowed-originto overrideThis finding was discovered by Project Loupe.