Revert "Bedrock model discovery and validation" - #10176
Conversation
This reverts commit 7026e14.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ff5d2984d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let model_exists = entry.default_model == model_id | ||
| || entry.models.iter().any(|model| model.id == model_id); |
There was a problem hiding this comment.
When saving defaults for a refreshable provider such as openai/OpenAI-compatible endpoints, a user can type a model that is not in the cached inventory; SwitchModelModal still supports that custom entry and sends it through acpSaveDefaults, but this check now rejects anything not already listed. That makes ACP desktop unable to save valid custom/compatible model IDs unless the inventory happens to contain them, regressing the manual custom-model flow for refreshable providers.
Useful? React with 👍 / 👎.
| const success = await changeModel(sessionId, modelObj); | ||
| if (success) { | ||
| onModelSelected?.(modelObj.name, modelObj.provider || ''); | ||
| trackModelChanged(modelObj.provider || '', modelObj.name); | ||
| onClose(); | ||
| } | ||
| } finally { | ||
| setIsSubmitting(false); | ||
|
|
||
| onClose(); |
There was a problem hiding this comment.
If changeModel returns false (for example because acpSaveDefaults or setSessionConfigOption failed and already showed an error toast), this unconditional close still dismisses the modal. In that failure path the model was not changed, so closing the dialog removes the user's chance to correct the provider/model selection and makes the failed switch look like it completed.
Useful? React with 👍 / 👎.
2 participants
Reverts #9997
This PR has reference to goosed api. We are in a progress to launch release that UI connects to ACP server without goosed, so revert this for now. Once our release is done, we can come back to fix the dependency on goosed for this PR