feat: associate threads with projects by matt2e · Pull Request #8745 · aaif-goose/goose

matt2e · 2026-04-22T03:09:44Z

Previously, the mapping from sessions to project was done in frontend storage
Add projectId to ThreadMetadata and expose it via session info _meta, so the backend is the source of truth for session-project associations
Add _goose/session/update_project custom RPC method to update a session's project association after creation
Pass projectId through session creation flow (UI → ACP tracker → newSession) so new sessions are associated with the correct project from the start
Update chatSessionStore to persist project changes to the backend and prefer the backend's projectId over the localStorage overlay

🤖 Generated with Claude Code

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63e094a7cd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-22T03:15:10Z

      overlay?.lastKnownTitle ??
      "Untitled",
-    projectId: overlay?.projectId,
+    projectId: session.projectId ?? undefined,


Fallback to overlay projectId when ACP metadata is missing

When listSessions returns a session without _meta.projectId (which is common for older threads), mergeAcpSessionWithOverlay now forces projectId to session.projectId ?? undefined instead of reusing the cached overlay value. In that case the project association disappears in UI, and syncOverlaySnapshots immediately persists null, permanently erasing the previously stored projectId from local overlay data. This regresses migration behavior for existing sessions that only have project linkage in overlay storage.

Useful? React with 👍 / 👎.

This is expected

baxen

LGTM!

projectId was stored only in browser localStorage, which is tied to the dev server port. When Vite picks a different port on restart, WebKit creates a separate localStorage and all project associations are lost. Thread project_id through the ACP backend: - on_new_session reads projectId from request meta - on_list_sessions returns projectId in _meta - New _goose/session/update_project extension method for moves - Frontend prefers backend projectId, falls back to overlay - createSession passes projectId to the backend - updateSession persists projectId changes to the backend - Extract thread_session_meta() helper to deduplicate _meta construction - Propagate projectId to forked sessions - Restore projectId in localStorage overlay for fallback resilience Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76f1c12aa8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da64a30aba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-22T05:23:20Z

+    if ("projectId" in patch && acpSessionId) {
+      updateSessionProject(acpSessionId, patch.projectId ?? null).catch(
+        (err: unknown) =>
+          console.error("Failed to update session project in backend:", err),
+      );


Serialize project-update calls to prevent stale writes

updateSession fires updateSessionProject as an untracked async side effect each time projectId is patched, so multiple rapid moves of the same session (for example A → B from the sidebar) issue concurrent RPCs with no ordering guarantee. If the earlier request resolves last, the backend thread metadata is reverted to the older project while the UI shows the newer one until a reload, causing persistent project mis-association. Queue or coalesce per-session project updates so only the latest value is committed.

Useful? React with 👍 / 👎.

The GooseClient SDK source exposes listSessions() (not prefixed with unstable_), matching the upstream ACP SDK. CI rebuilds the SDK from source before running typecheck, so it sees listSessions. The previous commit incorrectly used unstable_listSessions which only existed in a stale pre-built dist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b93a8e806

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-22T05:43:25Z

+    // Persist projectId change to ACP backend
+    const acpSessionId = updatedSession?.acpSessionId;
+    if ("projectId" in patch && acpSessionId) {
+      updateSessionProject(acpSessionId, patch.projectId ?? null).catch(


Serialize project metadata writes with session prep updates

updateSession fires updateSessionProject as an untracked async side effect, so the move-to-project path can send this RPC concurrently with acpPrepareSession follow-up calls that trigger provider/model metadata writes. On the backend, both on_update_session_project and other metadata setters use update_thread_metadata (read-modify-write), so concurrent requests can clobber each other and persist stale metadata depending on completion order. This means a single project move combined with provider/model changes can silently revert projectId; queue or await project updates before issuing other metadata-mutating RPCs for the same session.

Useful? React with 👍 / 👎.

The generated schema, meta, and TypeScript types were not committed alongside the backend changes that added _goose/session/update_project. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* main: (41 commits) removed the specific code owner for documentation change (#8749) fix(providers): handle missing delta field in streaming chunks (#8700) refactor(providers): extract http_status module and rename handle_status_openai_compat (#8620) fix(providers/openai): accept streaming chunks with both reasoning fields (#8715) feat: associate threads with projects (#8745) upgrade goose sdk and tui to be compatible with the latest agentclientprotocol/sdk package (#8667) feat: extend goose2 context window ux with auto-compaction (#8721) improve goose2 agent management flows (#8737) alexhancock/tui-improvements (#8736) fix: add strict:false to Responses API tools and gpt-5.4 to known models (#8636) persist and reliably apply chat model selection (#8734) merge goose-acp crate into goose (#8726) docs: AGENTS.md section on goose2 desktop backend architecture (#8732) feat: goose2 message bubble + action tray (#8720) consolidate provider ACP methods onto inventory (#8710) ci: declare and enforce MSRV of 1.91.1 (#8670) fix(ui): correct grammar in apps view description (#8668) (#8679) Stop load openai fast model for openapi compatible custom endpoint (#8644) feat(hooks): add Husky git hooks for ui/goose2 (#8577) fix: links in chat could not be opened (#8544) ...

* main: (34 commits) fix(goose-server): cache TLS cert to disk to avoid slow startup on first launch (#8174) feat: add Exa AI-powered search tool (#8487) fix: preprompt would show after loading session (#8744) commands to acp+ migration: extensions management (#8733) feat: desktop notification when goose finishes a task (#8647) harden code review skill for async state and default-resolution bugs (#8740) Feature/at agent mention (#8571) fix: removed hardcoded dependency of goose-acp-macro (#8753) perf: split agent setup into staged phases to reduce startup blocking (#8746) Add /skills command (#8600) Replace deprecated Claude ACP package links (#8625) removed the specific code owner for documentation change (#8749) fix(providers): handle missing delta field in streaming chunks (#8700) refactor(providers): extract http_status module and rename handle_status_openai_compat (#8620) fix(providers/openai): accept streaming chunks with both reasoning fields (#8715) feat: associate threads with projects (#8745) upgrade goose sdk and tui to be compatible with the latest agentclientprotocol/sdk package (#8667) feat: extend goose2 context window ux with auto-compaction (#8721) improve goose2 agent management flows (#8737) alexhancock/tui-improvements (#8736) ...

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

matt2e changed the title ~~feat: persist session-project association in ACP backend~~ feat: associate threads with projects Apr 22, 2026

baxen approved these changes Apr 22, 2026

View reviewed changes

matt2e and others added 2 commits April 22, 2026 15:02

fix: use unstable_listSessions method from GooseClient SDK

76f1c12

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

matt2e force-pushed the sessions-not-associated-with-project branch from 63e094a to 76f1c12 Compare April 22, 2026 05:05

style: fix cargo fmt import ordering in acp/server.rs

da64a30

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread ui/goose2/src/shared/api/acpApi.ts Outdated

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

chore: regenerate ACP schema and types for update_project endpoint

787d3dd

The generated schema, meta, and TypeScript types were not committed alongside the backend changes that added _goose/session/update_project. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

matt2e added this pull request to the merge queue Apr 22, 2026

Merged via the queue into main with commit c8b339e Apr 22, 2026
25 checks passed

matt2e deleted the sessions-not-associated-with-project branch April 22, 2026 07:22

github-actions Bot mentioned this pull request Apr 23, 2026

chore(release): release version 1.32.0 #8764

Closed

BrewTestBot mentioned this pull request Apr 23, 2026

block-goose-cli 1.32.0 Homebrew/homebrew-core#279029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: associate threads with projects#8745

feat: associate threads with projects#8745
matt2e merged 5 commits into
mainfrom
sessions-not-associated-with-project

matt2e commented Apr 22, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Uh oh!

matt2e Apr 22, 2026

Uh oh!

baxen left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

matt2e commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

matt2e Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

baxen left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matt2e commented Apr 22, 2026 •

edited

Loading