alexhancock/tui-improvements by alexhancock · Pull Request #8736 · aaif-goose/goose

alexhancock · 2026-04-21T19:59:25Z

Summary

A grab bag of three TUI improvements

Remove some permissioning code which looks to be around from early/experimental commits to this client that weren't being used
Fix scrolling which broke somehow, and make resize handling more robust
Redo the "expandable tool calls" UX. You can now arrow key between them and hit space to open one.

Testing

Local usage

Related Issues

N/A

Screenshots/Demos (for UX changes)

Screen.Recording.2026-04-21.at.3.56.28.PM.mov

chatgpt-codex-connector

💡 Codex Review

goose/ui/text/src/tui.tsx

Lines 743 to 745 in 9fc263f

    
           () => ({ 
        
             sessionUpdate: async (params: SessionNotification) => { 
        
               const update = params.update;

Handle ACP permission requests in interactive text UI

This GooseClient callback no longer provides a requestPermission handler, so the interactive TUI cannot answer ACP permission prompts for gated tool calls. On the server side, handle_tool_permission_request sends an ACP permission request and converts request errors into Permission::Cancel, which means these operations are automatically denied instead of letting the user approve them. Reintroduce a requestPermission callback here (or an explicit allow/deny policy) to avoid silently cancelling permission-gated actions.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-21T20:05:48Z

+      if (ch === " " && selectedToolCallIdx !== null) {
+        setToolCallExpandedScroll(0);
+        setToolCallExpanded(true);
        return;


Restrict space-to-expand shortcut while editing input

The global key handler opens the expanded tool-call view on any space press whenever a tool call is selected, without checking whether the prompt input is currently being edited. After selecting a tool call with arrows, pressing space while typing the next prompt will unexpectedly open the panel and disrupt normal message entry. Limit this shortcut to a non-editing context (or require a modifier) so space remains safe for typing.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-21T20:05:48Z

+      <Box key={`${keyPrefix}-hdr`} height={1}>
+        <Text color={TEXT_SECONDARY} bold>
+          {label}


Truncate expanded tool title in fixed-height row

This label is rendered inside a fixed height={1} row but uses default Ink wrapping. If info.title exceeds the available width, Ink wraps to extra lines and does not clip overflow for fixed-height boxes, which can break the expanded card layout. Render this row with truncation (and/or pre-truncate to width) to keep the height budget stable.

Useful? React with 👍 / 👎.

michaelneale

Can't wait for "goose" default cli to delegate to this!

alexhancock · 2026-04-21T22:36:00Z

@michaelneale A few more things IMO and then I think we can consider! 'Agree will be great

chatgpt-codex-connector

💡 Codex Review

goose/ui/text/src/tui.tsx

Lines 743 to 746 in 4ad2156

    
           () => ({ 
        
             sessionUpdate: async (params: SessionNotification) => { 
        
               const update = params.update; 
        
               if (update.sessionUpdate === "agent_message_chunk") {

Restore requestPermission callback for ACP tool approvals

This callback object now only exposes sessionUpdate, so the text TUI no longer handles ACP requestPermission RPCs. The server still issues those requests for approval-gated tools (handle_tool_permission_request in crates/goose/src/acp/server.rs), and failed permission requests are converted to Permission::Cancel, which means interactive text sessions can no longer approve sensitive tool calls that previously could proceed. Please keep a requestPermission handler here (and in --text mode) so approval-required workflows are not silently downgraded to cancellation.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-21T22:42:11Z

+  if (overflows) {
+    const above = startIdx;
+    elements.push(
+      <Box key="exp-up" width={safeWidth} height={1} justifyContent="center">


Constrain expanded panel filler rows to content width

The expanded body container is rendered at contentWidth, but this row uses width={safeWidth} (same pattern also appears in the pad/down rows), so overflow-state chrome is wider than its parent. In Ink, overflow is not clipped, so when the expanded tool output is scrollable (or padded), these rows can bleed into the card border/adjacent cells and break the fixed-height layout. Use contentWidth for these rows to keep the panel within its width budget.

Useful? React with 👍 / 👎.

* main: feat: extend goose2 context window ux with auto-compaction (#8721) improve goose2 agent management flows (#8737) alexhancock/tui-improvements (#8736) fix: add strict:false to Responses API tools and gpt-5.4 to known models (#8636) persist and reliably apply chat model selection (#8734) merge goose-acp crate into goose (#8726) docs: AGENTS.md section on goose2 desktop backend architecture (#8732) feat: goose2 message bubble + action tray (#8720) consolidate provider ACP methods onto inventory (#8710) ci: declare and enforce MSRV of 1.91.1 (#8670) fix(ui): correct grammar in apps view description (#8668) (#8679) Stop load openai fast model for openapi compatible custom endpoint (#8644)

* main: (41 commits) removed the specific code owner for documentation change (#8749) fix(providers): handle missing delta field in streaming chunks (#8700) refactor(providers): extract http_status module and rename handle_status_openai_compat (#8620) fix(providers/openai): accept streaming chunks with both reasoning fields (#8715) feat: associate threads with projects (#8745) upgrade goose sdk and tui to be compatible with the latest agentclientprotocol/sdk package (#8667) feat: extend goose2 context window ux with auto-compaction (#8721) improve goose2 agent management flows (#8737) alexhancock/tui-improvements (#8736) fix: add strict:false to Responses API tools and gpt-5.4 to known models (#8636) persist and reliably apply chat model selection (#8734) merge goose-acp crate into goose (#8726) docs: AGENTS.md section on goose2 desktop backend architecture (#8732) feat: goose2 message bubble + action tray (#8720) consolidate provider ACP methods onto inventory (#8710) ci: declare and enforce MSRV of 1.91.1 (#8670) fix(ui): correct grammar in apps view description (#8668) (#8679) Stop load openai fast model for openapi compatible custom endpoint (#8644) feat(hooks): add Husky git hooks for ui/goose2 (#8577) fix: links in chat could not be opened (#8544) ...

* main: (34 commits) fix(goose-server): cache TLS cert to disk to avoid slow startup on first launch (#8174) feat: add Exa AI-powered search tool (#8487) fix: preprompt would show after loading session (#8744) commands to acp+ migration: extensions management (#8733) feat: desktop notification when goose finishes a task (#8647) harden code review skill for async state and default-resolution bugs (#8740) Feature/at agent mention (#8571) fix: removed hardcoded dependency of goose-acp-macro (#8753) perf: split agent setup into staged phases to reduce startup blocking (#8746) Add /skills command (#8600) Replace deprecated Claude ACP package links (#8625) removed the specific code owner for documentation change (#8749) fix(providers): handle missing delta field in streaming chunks (#8700) refactor(providers): extract http_status module and rename handle_status_openai_compat (#8620) fix(providers/openai): accept streaming chunks with both reasoning fields (#8715) feat: associate threads with projects (#8745) upgrade goose sdk and tui to be compatible with the latest agentclientprotocol/sdk package (#8667) feat: extend goose2 context window ux with auto-compaction (#8721) improve goose2 agent management flows (#8737) alexhancock/tui-improvements (#8736) ...

alexhancock requested review from jamadeo, lifeizhou-ap and michaelneale April 21, 2026 19:59

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

michaelneale approved these changes Apr 21, 2026

View reviewed changes

alexhancock added 3 commits April 21, 2026 18:34

fix: remove unused permission settings

0b85dd1

fix: fix scrolling in the TUI

723f582

improvement(tui): better tool call expansion

4ad2156

alexhancock force-pushed the alexhancock/tui-improvements branch from 9fc263f to 4ad2156 Compare April 21, 2026 22:35

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

alexhancock added this pull request to the merge queue Apr 22, 2026

Merged via the queue into main with commit 23b3b3d Apr 22, 2026
23 checks passed

alexhancock deleted the alexhancock/tui-improvements branch April 22, 2026 00:57

github-actions Bot mentioned this pull request Apr 23, 2026

chore(release): release version 1.32.0 #8764

Closed

BrewTestBot mentioned this pull request Apr 23, 2026

block-goose-cli 1.32.0 Homebrew/homebrew-core#279029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

alexhancock/tui-improvements#8736

alexhancock/tui-improvements#8736
alexhancock merged 3 commits into
mainfrom
alexhancock/tui-improvements

alexhancock commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Uh oh!

michaelneale left a comment

Uh oh!

alexhancock commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	() => ({
	sessionUpdate: async (params: SessionNotification) => {
	const update = params.update;

Conversation

alexhancock commented Apr 21, 2026

Summary

Testing

Related Issues

Screenshots/Demos (for UX changes)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

michaelneale left a comment

Choose a reason for hiding this comment

Uh oh!

alexhancock commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants