ui: turn on extensions at startup#1861
Merged
Merged
Conversation
lilydelalande
force-pushed
the
ldelalande/turn-on-extensions-at-startup
branch
from
March 26, 2025 01:16
1c34e8e to
7d5990e
Compare
lilydelalande
commented
Mar 26, 2025
|
|
||
| const setupExtensions = async () => { | ||
| // First quickly check if we have model and provider to set chat view | ||
| const checkRequiredConfig = async () => { |
Contributor
Author
There was a problem hiding this comment.
rearranged code into this otherwise we were stuck on onboarding page until extensions finished loading
lilydelalande
commented
Mar 26, 2025
| @@ -78,21 +78,51 @@ export async function activateExtension({ | |||
| // AddToAgent | |||
Contributor
Author
There was a problem hiding this comment.
had to explicitly throw all errors to get the intended behavior..
alexhancock
approved these changes
Mar 26, 2025
| // Setup extensions in parallel | ||
| const setupExtensions = async () => { | ||
| // Set the ref immediately to prevent duplicate runs | ||
| initAttemptedRef.current = true; |
Collaborator
There was a problem hiding this comment.
Does anything read from this? It doesn't appear so. We can probably remove it.
| if (refreshedExtensions.length === 0) { | ||
| // If we still have no extensions, this is truly a first-time setup | ||
| console.log('First-time setup: Adding all built-in extensions...'); | ||
| await initializeBuiltInExtensions(addExtension); |
Collaborator
There was a problem hiding this comment.
Conceptual question.
If refreshedExtensions comes back the first time you ever boot the app as empty, is it any different/required to have a separate initializeBuiltInExtensions function? Could we just use a single syncBuiltInExtensions that behaves the same was as initialize if there were no extensions to begin with?
(No need to address this in this PR if it distracts - just trying to find opportunities to reduce complexity)
michaelneale
added a commit
that referenced
this pull request
Mar 26, 2025
* main: ui: turn on extensions at startup (#1861) ui: models dropdown (#1860) fix: cli empty line (#1856) feat: Allow setting OpenAI timeout from config (#1819) feat: add retry for google (#1854) feat(extensions): add Java/JDK support for MCP servers (#1816) feat: extract `StdioProcessError(msg)` to try to display (#1855) fix: show window bugfix (#1840) fix: append the attachment path to the existing text in the input prompt (#1842) docs: updated docs for smart approval mode (#1853) styles: chat scroll interaction (#1837) ui: add description field to modal (#1846) feat: use temp dir for extracting goose binary (#1838) ui: remove and update extensions (#1847) fix: disappearing user text when stopped (#1839)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on extensions at start up -- should toggle extensions that fail to start up to off but we get too many toasts so should fix that in follow-up: